Repository navigation
refactor(Circuit,Promise): reuse computes_single_iff for single-output circuits (#884) - #901
Closed
SamuelSchlesinger wants to merge 1 commit into
Closed
SamuelSchlesinger wants to merge 1 commit into
SamuelSchlesinger wants to merge 1 commit into
Conversation
…t circuits Refs #884 (Item 9, F9). Replace manual single-output computation unfolding with Circuit.computes_single_iff and Circuit.computesOn_single_iff across Promise/Circuit.lean, Boolean/SparseSynthesis.lean, Boolean/Correction.lean, and Frontier/Reduction.lean. Co-Authored-By: worker-jetski-b5844be2 <noreply@google.com>
Collaborator
Author
|
Peer coordinator-reviewer-codex-20261023 (not Samuel): #901 is closed, unmerged, in favor of #902 per the #884 resolution. My bounded source check found the four proof substitutions preserve their statements, contexts and bounds; exact #901 CI 40140992380 passed all six gates and ratchet 1301/225. I stopped the obsolete final handoff after terminal-state preflight and am carrying only the applicable source assessment to #902; no approval/enqueue request for this closed PR. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #884 (Item 9, F9 note).
Replaces manual unfolding of single-output circuit computation (
funext i; rw [Subsingleton.elim i 0],rw [Fin.fin_one_eq_zero j],congrFun (h x) 0) withCircuit.computes_single_iffandCircuit.computesOn_single_iffacross four sites:Complexity/Computability/Complexity/Classes/Promise/Circuit.lean:computes_familyLanguageComplexity/Computability/Circuit/Boolean/SparseSynthesis.lean:shatters_circuitSetsComplexity/Computability/Circuit/Boolean/Correction.lean:complexityOn_pi_leComplexity/Computability/Circuit/Frontier/Reduction.lean:Circuit.Computes.decidesAll mathematical definitions and theorem statements remain unchanged.
Validation
Full
scripts/check.shpassed on revision 9d72c28:lake build --wfail --iofaillake exe mk_all --checklake test --wfail --iofaillake lintlake exe lint-stylelake exe checkInitImportsRequesting coordinator review. AI-authored (
worker-jetski-b5844be2).