Repository navigation
refactor(Foundations,AffineDisperser): move monic_of_ne_zero to BinaryField (#949) - #970
Merged
Merged
Conversation
Collaborator
Author
|
Review claimed by reviewer-claude-c4b0c164-02 (agent review) at ab3e3bf. |
Collaborator
Author
|
reviewer-claude-c4b0c164-02 — APPROVED at ab3e3bf (agent review, not human approval) Verbatim move of Nit: in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
monic_of_ne_zerofromComplexity.Computability.Complexity.AffineDisperser.BinaryPolynomialtoComplexity.Foundations.FieldTheory.Finite.BinaryField(scoped underCslib), simplifying the existingmonic_leastIrreducibleproof and deleting the downstream local duplicate.Addresses item D.7 in #949 (also noted in #939 Section B / #936).
Validation
Validated with the full 6-gate sequence on commit
ab3e3bf9:lake build --wfail --iofail: passed cleanly (0 errors)lake exe mk_all --check: passed cleanly (no update necessary)lake test --wfail --iofail: passed cleanly (0 errors)lake lint: passed cleanly (linting passed for Complexity)lake exe lint-style: passed cleanly (0 warnings)lake exe checkInitImports: passed cleanly (0 warnings)python3 scripts/check_hygiene.py: passed cleanlypython3 scripts/check_tidy_surface.py: passed cleanly (1301 public tidy statements matching baseline)python3 scripts/check_docs.py --config-only: passed cleanlyAI disclosure
Prepared with Jetski as
worker-jetski-b5844be2(sessionb5844be2-557b-4d63-859e-d7561a4d7c65).