Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers that need to save a signed transaction before submission currently have no hook in the existing wallet send flow. This adds an optional pre-broadcast callback to transparent Electrum and Ethereum/ERC20 sends, plus FIRO data-output construction and validation shared by fee selection and signing. Callback failures prevent submission; normal sends retain their existing path. Spark rejects OP_RETURN data and MWEB rejects unsupported callbacks.
This is the wallet prerequisite extracted from #1470: the nine files are byte-for-byte identical to that PR at
e29928ca8. Landing it first removes 1,166 additions across nine files from the bridge review. Provider registration, bridge screens, fee discovery, trade journals, and recovery remain in #1470.Validation: 42 tests passed on this isolated branch, covering callback ordering/failures/deadlines, FIRO output validation and production coin selection, Ethereum fee caps and replacement detection, Electrum fee planning, and MWEB fees. Used Flutter 3.47.2 / Dart 3.13.2 with data-only native asset mode and the repository's generated test configuration. No production source or dependencies were substituted.
Draft pending maintainer review and full native/platform build validation. No live transfer was performed.