Repository navigation
fix(ci): use the NE_DOTNET_TARGETFRAMEWORKS variable for the mutation workflow SDKs - #1109
Merged
Merged
Conversation
… workflow SDKs The setup step referenced inputs.dotnetVersion, which the workflow never declared, so only 10.x was installed and net11.0 projects could not be built. Read the organization variable NE_DOTNET_TARGETFRAMEWORKS directly, falling back to 10.x when it is unset or empty.
Contributor
Author
|
Verification: probe caller in a throwaway branch of dailydevops/schemas, calling this branch (4c7b7a0) with no dotnetVersion input. Run: https://github.com/dailydevops/schemas/actions/runs/43998942819 - no startup failure; setup-dotnet received the org variable value (a multi-line SDK list starting at 6.x in the log, so the vars context resolves in the called workflow); Stryker identified and mutated the projects of Schemas.slnx and the run ended with success, final mutation score 86.07 %. Not verified: a caller with the variable unset (the 10.x fallback path). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mutation-dotnet.yml(introduced in #1108, released as 2.7.9) used${{ inputs.dotnetVersion || '10.x' }}in the setup-dotnet step, butworkflow_callonly declaresconfigurationFile. Two consequences:dotnetVersion:fails at startup (startup_failure), because the input is not declared: https://github.com/dailydevops/schemas/actions/runs/4399859873410.xonly, so projects targetingnet11.0cannot be built (NETSDK1045).Fix
Read the organization variable
NE_DOTNET_TARGETFRAMEWORKSdirectly in the setup-dotnet step, with10.xas the fallback when it is unset or empty:The dead
inputs.dotnetVersionreference is removed. No newworkflow_callinput is added.Compatibility
Callers need no change (no new
with:entries, secrets unchanged). In a reusable workflow, thevarscontext is resolved from the caller's repository and organization. A caller that still passesdotnetVersion:keeps failing at startup, as it does today, since the input does not exist.Verification
Probe caller in a throwaway branch of a consuming repository, pointing the reusable call at this branch and passing no
dotnetVersion. Result is recorded in a comment on this PR.