canonicalize double exclamation !! to speak as double factorial - #837
AdamMagued wants to merge 1 commit into
Conversation
Linux library size: 0.58 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
|
When I wrote this issue, I didn't even catch that it's already covered and just needs to be normalized. @NSoiffer what do you think? Also, I've not really worked with the |
|
Hi @moritz-gross, Thank you for the review and the insight! Normalizing it so !! canonicalizes consistently to double factorial ensures speech synthesis and navigation behave as expected across different MathML representations. Happy to make any further adjustments if @NSoiffer or the team have suggestions! |
|
@AdamMagued Neil is busy for a few days now, so we likely won't get to review this PR in this week. We'll comment if anything comes up. thanks for your work |
Resolves #806.
When
!!is encountered in<mo>!!</mo>, it was previously left as literal ASCII exclamation marks and spoken as"5 !!"rather than"5 double factorial".This change:
"!!"to"\u{203C}"("‼") incanonicalize_mo_text, aligning with the existing rules for double factorial across languages."‼"tooperator-info.inwith postfix operator type and priority 810 (matching single and double factorial operators).symbols_and_adornments.rsverifying that<math><mn>5</mn><mo>!!</mo></math>produces"5 double factorial"in ClearSpeak and SimpleSpeak.