Repository navigation
Correct runnable examples and reference errors in the lesson - #644
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct small, independently reproducible errors in the canonical lesson sources (no generated site changes):
Validation
At main 535175e, executing the relevant documented snippets reproduces unmatched-parenthesis SyntaxError, missing-con TypeError, integer-year concatenation TypeError, and mkdir(./) FileExistsError. The original date filter excludes a synthetic September-15 noon observation. Each affected path passes after these changes; the writer now supplies actual filenames to its caller.
Checked with Python 3.13.13, pandas 2.3.3, NumPy 2.3.2, Matplotlib 3.11.2 and plotnine 0.15.8, using tiny invented DataFrames and an in-memory SQLite database (not research data). Also exercised read/write, selection, copying, grouping, joins, yearly-file functions and all current episode-07 Python fences with synthetic data, drawing 27 plot expressions. Verified that outer and cross joins differ, negative float conversion truncates towards zero, and the dictionary output matches the preceding commands. git diff --check passes.
Limits: no full Sandpaper validation/site build (R/Rscript/Pandoc unavailable), browser acceptance, Anaconda/conda installation, Python-3.8 environment check or verification of all supplied dataset statistics/images. The legacy supplemental notebooks are unchanged. Intentional teaching errors are preserved.
Existing PRs #640 and #626 cover different plotting/combination examples; their changes are deliberately not duplicated here.