Repository navigation
CLARIN-DSpace v9: fix double encoding of CLARIN license names containing '+' - #1638
Open
milanmajchrak wants to merge 1 commit into
Open
milanmajchrak wants to merge 1 commit into
milanmajchrak wants to merge 1 commit into
Conversation
…ing '+' Port of dtq-dev PR 1596 (commit c3c44fc) to the v9 base, written for the 9.x spec. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Port of dtq-dev PR 1596 (commit c3c44fc).
Description
findClarinLicenseByName()encoded a license name with+once more thanRequestParamalready does, so thebyNamelookup asked forGNU%2520GPL%25202.0%252Band found nothing. The extraencodeURIComponentis gone.Instructions for Reviewers
section-license.component.ts: theif (licenseName.includes('+'))block is removed,RequestParamencodes the value itself since the 7.6.5 upgradebyNamequery isname=GNU%20GPL%202.0%2BforGNU GPL 2.0+andname=Licence%20A%20%26%20BforLicence A & Bsection-license.component.spec.tspasses locally (17 tests), eslint cleanChecklist
🤖 Generated with Claude Code