Repository navigation
Add FLUX Pro models and a per-user default model per kind - #57
Merged
Merged
Conversation
Video Creator takes the first catalogue model of a kind when nothing names one, and the first text-to-image row was FLUX.1 [schnell], the draft model. So every picture its assistant made, and every Generate left on its first choice, came out at draft quality. - Seed FLUX1.1 [pro] ultra, FLUX.2 [pro] and FLUX1.1 [pro] (migration b7d41e9c2a60), sorted ahead of schnell. Field names and enums checked against @fal-ai/client 1.11.0-alpha.6's endpoint types. Rows an admin already added are left alone, and the downgrade removes only rows nobody has edited. - Each user can choose a default model per kind in Settings (`default_models` on /api/settings/generation, stored by endpoint id). /api/generate/models lists that model first in its kind and flags it `is_default`, so a caller that takes the first entry follows it unchanged. - The generate form starts on the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1geD2VRs3zvsfpXEqKmzn
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V1geD2VRs3zvsfpXEqKmzn
davior
marked this pull request as ready for review
November 2, 2026 04:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When nothing names a model, Video Creator takes the first catalogue model of the kind. The first text → image row was FLUX.1 [schnell], the draft model. So every picture GVC's assistant made, and every Generate left on its first choice, came out at draft quality. There was also no FLUX Pro model to choose instead.
What
Three FLUX Pro rows (migration
b7d41e9c2a60), sorted ahead of schnell (sort order 5–7 against 10):fal-ai/flux-pro/v1.1-ultrafal-ai/flux-2-pronum_images)fal-ai/flux-pro/v1.1@fal-ai/client1.11.0-alpha.6's generated endpoint types.A per-user default model per kind (
app/generation/defaults.py):PUT /api/settings/generationtakesdefault_models: {kind: endpoint_id | null}. It's stored by endpoint id under the setting keydefault_generation_models, so no schema change is needed. An endpoint that isn't an active row of that kind is refused with422 invalid_default_model, and nothing in the request is saved.GET /api/generate/modelslists the default first in its kind and flags itis_default. Because it comes first, a caller that takes the first entry (GVC, or anything older than the flag) follows the user's choice unchanged. A default that was switched off reads as no default.Tests
pytest -q, 1479 passed. New tests cover the seed and its downgrade (test_migrations.py) and the defaults (test_generation_defaults.py).npm test, 456 passed.npm run buildpasses.Pairs with the GVC change that lets a project choose its own models (S6). That change works without this one, but the per-user default needs this.
Generated by Claude Code