Repository navigation
fix: make simd4f::sum() consistent across all SIMD paths - #3172
Merged
Merged
Conversation
The SSE2 path used _mm_movehl_ps which gives a different result from the SSE3/AVX hadd path for certain inputs. The NEON path used vadd_f32 instead of vpadd_f32, likewise giving different results. Fix both to match the SSE3 behaviour.
Owner
|
Thanks @lippinj for making the SIMD reduction grouping consistent across these backends. I checked the grouping and downstream FHOG behavior; this looks good as submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE2 path used _mm_movehl_ps which gives a different result from the SSE3/AVX hadd path for certain inputs. The NEON path used vadd_f32 instead of vpadd_f32, likewise giving different results. Fix both to match the SSE3 behaviour.