Repository navigation
fix(storage): index the columns behind ON DELETE SET NULL - #34
Merged
Merged
Conversation
Every deleted symbol looked up its children in chunks and symbols with a full table scan, so removing files from a large index took hours. Existing indexes gain both indexes on their next open. Fixes #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
symbols.parent_idandchunks.symbol_idreferencesymbols(id)withON DELETE SET NULLbut have no index. Withforeign_keys = ON, every deleted symbol scans both tables, so removing files costs O(deleted symbols x table rows) and runs into hours on a large index.Solution
Add
idx_symbols_parentandidx_chunks_symboltoschema.sqland mirror them indocs/SCHEMA.md.Verification
foreign_key_checkstays clean.Compatibility
_apply_schema()runs on every open withIF NOT EXISTS, so existing indexes pick these up on their next open. No schema version bump, no rebuild.Fixes #33