Repository navigation
Refactor I/O and add initial NetCDF support - #59
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring and (work toward) improvement of
jigsaw's I/O pathways, designed to simplify the implementation as well as support new high(er)-performance file types:*.mshfile reader has been refactored into a templated system, allowing the ASCII, NetCDF and API workflows to share a (mostly) common implementation.*.jigfile reader (and underlying data-structures) have likewise been simplified to reduce duplication.*.ncschema is a close match to the existing ASCII*.mshformat, replicating the same arrays and naming conventions. This is intended to provide a drop-in replacement for existing*.mshfile-based workflows by simply swapping files to equivalent*.ncformat inputs. Updates to the Python bindings and subsequent testing is TBD, so the*.ncfeature is still WIP.