Repository navigation
A simple update to optimisation re-ordering - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a simple improvement to the cell quality heutristic used to determine the node ordering applied in the Symmetric Gauss-Seidel iteration. Each node is assigned a priority score
c, with the iteration scanning nodes in order of decreasing prioritiesHere,$\overline{Q}$ is the mean quality of the cells incident to the node in question, $Q_{0}$ is the minimum quality in the same set, and $Q^{*}$ is the global threshold $\lambda=\frac{1}{4}$ was chosen empirically.
opts.optm_qlim. The relative weighting factorPreviously, priorities were computed using only the first term above, which promotes nodes adjacent to large differences in cell quality, which is often correlated with opportunities for node smoothing.
The second term added in this PR is a cell quality magnitude contribution, promoting nodes adjacent to low quality cells. In practice, this tends to help improve the worst quality cells in the mesh.