Skip to content

tighten plan view tests - #189

Merged
atkrad merged 1 commit into
mainfrom
tighten-plan-view-tests
Oct 13, 2026
Merged

atkrad merged 1 commit into
mainfrom
tighten-plan-view-tests

Conversation

@atkrad

@atkrad atkrad commented Oct 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Report the golden path and -update when a plan view golden mismatches, without writing files on a normal run.
  • Reject the remaining invalid drift, task, hook, and chart CRD enums from both plan writers.
  • Check that drift and hook-definition secrets stay on the original plan after rendering.

Related

Test plan

  • Unit tests added/updated
  • Scenario under scenarios/ (if behavior changes)
  • nix run .#lint / pre-commit clean
  • Manual smoke (command + expected result), if user-facing

Labels

  • One of: kind/feature, kind/bug, kind/docs, kind/chore
  • Add breaking-change if this breaks existing CLI or config behavior
  • Add skip-changelog for internal-only PRs that should not appear in notes

Checklist

  • Title is short and imperative (matches commit style)
  • Docs / CLI help updated when user-facing (README.md, docs/cli/)
  • No secrets or local-only paths in the diff

@atkrad atkrad added kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes labels Oct 13, 2026
@github-actions github-actions Bot added the area/deploy Deploy and plan session flow label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@atkrad atkrad self-assigned this Oct 13, 2026
@atkrad
atkrad merged commit 1d4ab55 into main Oct 13, 2026
17 checks passed
@atkrad
atkrad deleted the tighten-plan-view-tests branch October 13, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy Deploy and plan session flow kind/chore Cleanup, deps, CI, or refactor with no user-facing change skip-changelog Exclude this PR from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant