Repository navigation
feat(auth): say when a dcd login session has expired - #303
Merged
Merged
Conversation
When Supabase Auth refuses to refresh a `dcd login` session, the CLI used
to echo its message ("Failed to refresh session: Invalid Refresh Token:
Session Expired. Run `dcd login` again."). It now names the two common
causes, keyed on the error code Supabase sends:
- `session_expired` (the session passed the project's maximum length or
inactivity timeout): "Your session expired. Run `dcd login` to sign in
again."
- `session_not_found` / `refresh_token_not_found` (the session was ended):
"Your session was signed out. Run `dcd login` to sign in again."
Other refusals keep Supabase's message. The code is kept on
SessionRefreshError. supabase-js reports `session_not_found` as an
AuthSessionMissingError rather than an AuthApiError, so that case was
treated as a transient failure and retried; it is now final like any other
refusal.
A poll that loses its session no longer repeats itself ("session expired
and could not be refreshed: Your session expired"): it shows the refresh
error, then the reconnect command. dcd-mcp gets the new text through
runTool.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Supabase Auth refuses to refresh a
dcd loginsession, the CLI used to echo its message ("Failed to refresh session: Invalid Refresh Token: Session Expired. Rundcd loginagain."). It now names the two common causes, keyed on the error code Supabase sends:session_expired(the session passed the project's maximum length or inactivity timeout): "Your session expired. Rundcd loginto sign in again."session_not_found/refresh_token_not_found(the session was ended): "Your session was signed out. Rundcd loginto sign in again."Other refusals keep Supabase's message. The code is kept on SessionRefreshError. supabase-js reports
session_not_foundas an AuthSessionMissingError rather than an AuthApiError, so that case was treated as a transient failure and retried; it is now final like any other refusal.A poll that loses its session no longer repeats itself ("session expired and could not be refreshed: Your session expired"): it shows the refresh error, then the reconnect command. dcd-mcp gets the new text through runTool.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test