Repository navigation
Fix GTK toolbar artifacts in screen captures - #418
Merged
Merged
Conversation
The menu-constrained case needs a compositor that shrinks an oversized popup. Weston 13 on the Ubuntu 24.04 CI runner does not shrink it, so the menu never overflows and the case fails before capture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom GTK styles can leave toolbar backgrounds, borders, shadows, or proof-widget paint in screenshots. Clear these surfaces above user CSS priority and disable transitions and animations during capture.
Keep popover geometry stable with app-owned shadows in normal and capture states. Preserve compositor-constrained menu dimensions during capture, then restore the original content and layout.
Validation:
Vulkan was unavailable. The existing configurator GTK scenario fails at Weston's default output size and passes at 1920×1080.
Closes #417.