Skip to content

#2769: fix GUI prompt loop and prevent duplicate IDE launches - #2780

Open
shodiBoy1 wants to merge 5 commits into
devonfw:mainfrom
shodiBoy1:feature/2769-gui-invalid-answer-loop
Open

shodiBoy1 wants to merge 5 commits into
devonfw:mainfrom
shodiBoy1:feature/2769-gui-invalid-answer-loop

Conversation

@shodiBoy1

@shodiBoy1 shodiBoy1 commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes #2769

Implemented changes

  • Disable the clicked IDE's Open button while its launch task runs and ignore repeated requests for the same IDE. The button is enabled again when the task finishes, fails, or is cancelled. Other IDE buttons remain available.
  • Abort GUI questions that require a choice instead of repeatedly reading an empty answer and flooding the console with Invalid answer warnings. Existing default answers and batch behavior are preserved.
  • Add regression tests for prompt handling, duplicate launches, and button states.

Testing instructions

  1. Run com.devonfw.ide.gui.AppLauncher from the gui module using Java 25. Set IDE_ROOT to an existing IDEasy root directory.
  2. Select a project and workspace.
  3. Double-click Open for IntelliJ, Eclipse, or Android Studio. Only the clicked button should be disabled, and only one launch task should start.
  4. Check that the other IDE buttons remain enabled.
  5. Once the launch task finishes or fails, check that its Open button is enabled again.

Checklist for this PR

  • Local build and tests pass with mvn -q clean verify -pl '!documentation'
  • PR title is of the form #«issue-id»: «brief summary»
  • PR description summarizes the changes and links the addressed issue
  • PR and issue have suitable labels
  • Issue is set to In Progress and assigned to me
  • Followed the coding conventions
  • Added the issue to CHANGELOG.adoc
  • No dependencies were changed, so no LICENSE update is needed
  • Added clear testing instructions

Checklist for GUI contributions

@coveralls

coveralls commented Nov 1, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 41933574711

Coverage increased (+0.07%) to 75.355%

Details

  • Coverage increased (+0.07%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 34 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

34 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/ide/gui/core/service/CommandletService.java 21 65.0%
com/devonfw/ide/gui/core/context/IdeGuiContext.java 10 42.31%
com/devonfw/ide/gui/feature/ide/launcher/IdeLauncherViewModel.java 3 60.0%

Coverage Stats

Coverage Status
Relevant Lines: 19943
Covered Lines: 15690
Line Coverage: 78.67%
Relevant Branches: 8870
Covered Branches: 6022
Branch Coverage: 67.89%
Branches in Coverage %: Yes
Coverage Strength: 3.38 hits per line

💛 - Coveralls

@shodiBoy1 shodiBoy1 added macOS specific for Apple MacOS GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx and removed macOS specific for Apple MacOS labels Nov 2, 2026
@shodiBoy1
shodiBoy1 marked this pull request as ready for review November 2, 2026 11:56
@shodiBoy1 shodiBoy1 moved this from 🆕 New to Team Review in IDEasy board Nov 2, 2026
@laim2003
laim2003 self-requested a review November 3, 2026 09:43
@laim2003 laim2003 self-assigned this Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Double-clicking an open button for an IDE in the GUI causes endless "Invalid answer" warnings in the console

3 participants