Skip to content

Trim dor-cli.md back under its spec word budget - #783

Closed
dormouse-bot wants to merge 1 commit into
mainfrom
fix/ci-36029711184
Closed

dormouse-bot wants to merge 1 commit into
mainfrom
fix/ci-36029711184

Conversation

@dormouse-bot

Copy link
Copy Markdown
Collaborator

pnpm test on main fails at its first step since #780: docs/specs/dor-cli.md is at 6314 words against its 6300-word budget in scripts/spec-word-budgets.json (failed run). #780 added a four-line launcher exit-status rule to the spec. Its branch was based on #772, before the browser PRs (#773–#778) also edited this spec. Each branch was under budget on its own, but the merged result is not. Because pnpm test chains every step with &&, the other lints and package tests after spec-lint did not run on main either.

This trims the spec by 14 words instead of raising the budget. No rule is dropped:

  • The new launcher rule keeps its bolded imperative, its one why-clause (scripts and dor await callers branch on the exit status), and its pointer to dor/test/launcher.test.mjs on the Windows standalone-platform-check leg.
  • Two other passages are shortened. The host:port "pure string rewrite" sentence is reworded. Under ## Future, the "Additional dor list filters" item drops its redundant lead-in ("activity/state filters are deliberately deferred") and the word "possible", so it now just lists the deferred flags.

Locally, node scripts/spec-lint.mjs reports OK (35 specs, 69 files checked) and spec-lint-selftest passes. For both checks I added a placeholder standalone/sidecar/node_modules because this checkout has no installed dependencies. The other root-level lints in pnpm test also pass locally. The package tests are left to CI.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2eefc96
Status: ✅  Deploy successful!
Preview URL: https://b29f48dc.mouseterm.pages.dev
Branch Preview URL: https://fix-ci-36029711184.mouseterm.pages.dev

View logs

@nedtwigg

nedtwigg commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

@nedtwigg nedtwigg closed this Sep 24, 2026
@nedtwigg
nedtwigg deleted the fix/ci-36029711184 branch September 24, 2026 17:16

This branch is waiting to be deployed

1 waiting deployment
hosted-preview — 2eefc96a Waiting Sep 24, 2026 by nedtwigg via cleanup #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants