You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
BUG: Make local PostgreSQL secret instructions safe and consistent #114
Make the local PostgreSQL secret instructions safe, repeatable, and consistent across the local SIT guide and Infra SIT procedure.
Root Cause Evidence
The .github local-SIT guide says database passwords must not enter shell history and describes interactive secret creation, but the linked infra-sit README uses kubectl create secret ... --from-literal=POSTGRES_PASSWORD=postgres, which is non-interactive and can enter shell history.
Scope
Target repositories: infra-sit and .github.
Eliminate the contradiction between docs/local-sit.md and the Infra SIT README.
Use local-only, non-secret credential handling appropriate for an instructional local SIT environment.
Avoid tokens and production credentials.
Acceptance Criteria
Neither guide claims --from-literal avoids shell history.
The .github guide and Infra SIT procedure agree on the local-only credential approach.
The documented command is repeatable.
No token, production credential, or real secret is introduced.
Expected Repository / PR Boundary
One focused documentation PR in digital-bank-java/infra-sit, plus a linked documentation PR in digital-bank-java/.github only if docs/local-sit.md requires an update.
Non-goals
No service business-code change.
No Helm behavior change unless another source of truth proves the documented tag is wrong.
No UAT or PROD scope.
Verification
Review the changed documentation and chart image tag together.
On a clean local Docker cache, build the documented image tag and confirm it is the tag selected by the local SIT chart.
Taking this now. I am replacing shell-literal PostgreSQL secret creation with a safe interactive local SIT procedure and will verify Helm render before opening the PR.
Activity
ramioooz commentedon Aug 2, 2026
Taking this now. I am replacing shell-literal PostgreSQL secret creation with a safe interactive local SIT procedure and will verify Helm render before opening the PR.