Skip to content

BUG: Make local PostgreSQL secret instructions safe and consistent #114

Closed
digital-bank-java/infra-sit
#21

Description

@ramioooz

Objective

Make the local PostgreSQL secret instructions safe, repeatable, and consistent across the local SIT guide and Infra SIT procedure.

Root Cause Evidence

The .github local-SIT guide says database passwords must not enter shell history and describes interactive secret creation, but the linked infra-sit README uses kubectl create secret ... --from-literal=POSTGRES_PASSWORD=postgres, which is non-interactive and can enter shell history.

Scope

  • Target repositories: infra-sit and .github.
  • Eliminate the contradiction between docs/local-sit.md and the Infra SIT README.
  • Use local-only, non-secret credential handling appropriate for an instructional local SIT environment.
  • Avoid tokens and production credentials.

Acceptance Criteria

  • Neither guide claims --from-literal avoids shell history.
  • The .github guide and Infra SIT procedure agree on the local-only credential approach.
  • The documented command is repeatable.
  • No token, production credential, or real secret is introduced.

Expected Repository / PR Boundary

One focused documentation PR in digital-bank-java/infra-sit, plus a linked documentation PR in digital-bank-java/.github only if docs/local-sit.md requires an update.

Non-goals

  • No service business-code change.
  • No Helm behavior change unless another source of truth proves the documented tag is wrong.
  • No UAT or PROD scope.

Verification

  • Review the changed documentation and chart image tag together.
  • On a clean local Docker cache, build the documented image tag and confirm it is the tag selected by the local SIT chart.

Activity

  1. self-assigned this
    on Aug 2, 2026
  2. added theissue type on Aug 2, 2026
  3. ramioooz commented on Aug 2, 2026

    @ramioooz
    MemberAuthor

    Taking this now. I am replacing shell-literal PostgreSQL secret creation with a safe interactive local SIT procedure and will verify Helm render before opening the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions