Skip to content

TASK: Enable ledger-driven transfer event flow in SIT #213

Closed
2 of 2 issues completed
digital-bank-java/config-repo
#44

Description

@ramioooz

Parent

Objective

Enable the already-implemented transaction, account, and ledger Kafka adapters in the local SIT environment so a transfer can progress through reservation, ledger posting, ledger outcome, and transfer-state completion or failure.

Scope

  • Enable Account Service reservation transport and ledger outcome consumption in digital-bank-sit.
  • Enable Transaction Service ledger command publication and ledger outcome consumption in digital-bank-sit.
  • Enable Ledger Service posting-command consumption and ledger outbox delivery in digital-bank-sit.
  • Use the existing SIT Kafka broker, governed topic names, consumer groups, retry settings, and explicit SIT-only plaintext allowance.
  • Keep AWS/UAT/PROD configuration out of scope.

Acceptance Criteria

  • Config Server serves the expected SIT transport properties for Account, Transaction, and Ledger Services.
  • After rollout, all three services remain healthy and Kafka consumers start without configuration errors.
  • A representative SIT transfer can be traced through reservation, ledger posting, ledger outcome, and transaction workflow state.
  • Duplicate delivery remains idempotent and deterministic failures are routed to the existing DLQ conventions.
  • AKHQ shows the governed transfer and ledger topics and consumer groups.
  • No direct public balance mutation endpoint or public ledger posting route is introduced.

Related Work

Delivery

This is a Config Repo change. Merge after any required topic-provisioning PRs and before restarting the three consumers. No fixed delay is required; wait until Config Server serves the new revision, then roll out the consumers and verify the flow.

Activity

  1. self-assigned this
    on Sep 4, 2026
  2. added theissue type on Sep 4, 2026
  3. ramioooz commented on Sep 4, 2026

    @ramioooz
    MemberAuthor

    Local SIT runtime validation completed on 2026-09-05 using the locally built feature images for the two previously failing services.

    Evidence:

    • All 10 SIT deployments are available: Account, API Gateway, Auth, Config Server, Customer, Ledger, MFA, Notification, Payment, and Transaction Service.
    • Account Service consumers joined the reservation and ledger-outcome groups and received the expected governed topic partitions.
    • Transaction Service consumers joined the reservation and ledger-outcome groups and received the expected governed topic partitions.
    • Payment Service is Ready with zero restarts and connected to payment_service; Flyway completed successfully.
    • Notification Service is Ready with zero restarts; Flyway completed successfully and the Kafka-enabled application context started.

    Review PRs still pending:

    The local cluster used feature-branch images for validation. The permanent deployment state should be rolled out again after the corresponding PRs are merged.

  4. ramioooz commented on Sep 5, 2026

    @ramioooz
    MemberAuthor

    SIT checkpoint (2026-09-05)

    Verified in the local digital-bank-sit cluster:

    • Config Server serves the expected SIT source chain for transaction-service, account-service, and ledger-service: service-specific *-sit.yml, shared application-sit.yml, service defaults, and shared defaults.
    • Account Service has active reservation and ledger-outcome listener containers with assigned partitions.
    • Transaction Service has active reservation, ledger-outcome, and MFA-assurance listener containers with assigned partitions.
    • All application deployments are Ready 1/1.

    Remaining evidence/dependencies:

    • infra-sit#34 must merge and be reconciled so mfa.assurance.granted.v1.dlq is explicitly provisioned.
    • A representative transfer still needs to be traced through reservation, ledger posting, ledger outcome, and final transaction state.
    • Duplicate delivery and deterministic DLQ behavior still require verification.

    No secrets or message payloads were recorded.

  5. ramioooz commented on Sep 5, 2026

    @ramioooz
    MemberAuthor

    Updated SIT infrastructure checkpoint (2026-09-05)

    After merged infra-sit#34, the governed event topics and DLQs are provisioned, including mfa.assurance.granted.v1 and its DLQ. The active consumer groups now include Account reservation/ledger outcomes, Transaction reservation/ledger/MFA assurance, and Notification transfer-created consumption. Notification Service is running the validated listener image and has an assigned events.transfer.created.v1-0 partition.

    The remaining acceptance work is a controlled representative transfer trace plus duplicate delivery and deterministic DLQ verification. No secrets or message payloads were recorded.

  6. ramioooz commented on Sep 5, 2026

    @ramioooz
    MemberAuthor

    Config Repo status

    The SIT transport configuration requested by .github#213 is already present on main through config-repo#41. I verified the current origin/main revision in an isolated worktree:

    • Account reservation transport and ledger outcome consumers are enabled with the governed reservation/ledger topics, consumer groups, retry values, and .dlq recovery convention.
    • Transaction ledger command publication and ledger outcome consumption are enabled with ledger.posting.*.v1, group transaction-service-ledger, bounded exponential retry, and .dlq recovery.
    • Ledger posting-command consumption and outbox delivery are enabled for ledger.posting.requested.v1, group ledger-service; the SIT infra topic set includes the governed source topics and .dlq companions.
    • SIT Kafka is explicitly PLAINTEXT only in the SIT profile, with the existing Account allow-insecure-transport and Transaction sit-plaintext-enabled safeguards.

    Focused verification passed: all 20 tracked YAML files parsed, the required transport contract checks passed, and git diff --check passed. No follow-up Config Repo PR is opened because the requested settings are already merged and a duplicate/no-op PR would violate the scope.

    Related work: ledger-service#18, transaction-service#13, transaction-service#18, account-service#38, infra-sit#23, and infra-sit#29.

    The Config Repo portion is complete; keep this task In progress pending the representative transfer trace plus duplicate-delivery and deterministic-DLQ verification. Rollout is readiness-based: ensure the related service images and required topic provisioning are available, wait until Config Server serves the revision, then roll out Account, Transaction, and Ledger Services. No fixed delay is required between merges or rollout steps. AWS/UAT/PROD remain out of scope.

  7. ramioooz commented on Sep 5, 2026

    @ramioooz
    MemberAuthor

    Implementation update: the existing merged SIT config enabled ledger transport but omitted Transaction Service reservation topic names, consumer group, and publisher retry/lease settings required by the already-existing Kafka adapters. Config Repo PR digital-bank-java/config-repo#44 adds only those missing non-secret values under transaction-service/transaction-service-sit.yml. Local YAML parsing, required-property assertions, whitespace validation, and secret-pattern checks pass. After merge, refresh Config Server and roll out Transaction, Account, and Ledger Services in digital-bank-sit for end-to-end verification.

  8. ramioooz commented on Sep 5, 2026

    @ramioooz
    MemberAuthor

    Implementation is available in config-repo#44. It adds the missing SIT reservation transport properties for Transaction Service, including governed topics, consumer group, retry policy, and publisher lease/retry settings. Account and Ledger SIT transport settings were already present on the configuration baseline. Verification passed: YAML parsing, required-property checks, diff hygiene, and secret scan. Merge this PR before refreshing Config Server and rolling out the three consumers for end-to-end SIT verification.

  9. ramioooz commented on Sep 6, 2026

    @ramioooz
    MemberAuthor

    Added PR #253 to align the Insomnia transfer workflow guide with the merged event-driven implementation.

    The guide now distinguishes implemented behavior from remaining Sprint 3 SIT acceptance evidence: successful completion, insufficient-balance failure and release, duplicate delivery, malformed-event/DLQ handling, and Account/Ledger/Transaction/Kafka/AKHQ-DBeaver correlation. No runtime code or redundant tests were added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions