Repository navigation
Closed
Copy link
Description
Parent
- Parent Story: STORY: Orchestrate transfer saga with ledger-driven completion #103
- Parent Epic: EPIC: Sprint 3 - Internal Transfers and Event Consistency #21
Objective
Enable the already-implemented transaction, account, and ledger Kafka adapters in the local SIT environment so a transfer can progress through reservation, ledger posting, ledger outcome, and transfer-state completion or failure.
Scope
- Enable Account Service reservation transport and ledger outcome consumption in
digital-bank-sit. - Enable Transaction Service ledger command publication and ledger outcome consumption in
digital-bank-sit. - Enable Ledger Service posting-command consumption and ledger outbox delivery in
digital-bank-sit. - Use the existing SIT Kafka broker, governed topic names, consumer groups, retry settings, and explicit SIT-only plaintext allowance.
- Keep AWS/UAT/PROD configuration out of scope.
Acceptance Criteria
- Config Server serves the expected SIT transport properties for Account, Transaction, and Ledger Services.
- After rollout, all three services remain healthy and Kafka consumers start without configuration errors.
- A representative SIT transfer can be traced through reservation, ledger posting, ledger outcome, and transaction workflow state.
- Duplicate delivery remains idempotent and deterministic failures are routed to the existing DLQ conventions.
- AKHQ shows the governed transfer and ledger topics and consumer groups.
- No direct public balance mutation endpoint or public ledger posting route is introduced.
Related Work
- Ledger implementation: feat: consume ledger posting commands ledger-service#18
- Transaction transport and saga implementation: feat: integrate transfer workflow and event transport transaction-service#13, EPIC: Sprint 0 - Platform Foundation and Local SIT #18
- Account ledger outcome consumer: feat: integrate account transport stack with quality gate account-service#38
- Existing SIT topic provisioning: feat: provision SIT ledger Kafka topics infra-sit#27 and EPIC: MFA Provider Service #29
Delivery
This is a Config Repo change. Merge after any required topic-provisioning PRs and before restarting the three consumers. No fixed delay is required; wait until Config Server serves the new revision, then roll out the consumers and verify the flow.
Activity
ramioooz commentedon Sep 4, 2026
Local SIT runtime validation completed on 2026-09-05 using the locally built feature images for the two previously failing services.
Evidence:
payment_service; Flyway completed successfully.Review PRs still pending:
The local cluster used feature-branch images for validation. The permanent deployment state should be rolled out again after the corresponding PRs are merged.
ramioooz commentedon Sep 5, 2026
SIT checkpoint (2026-09-05)
Verified in the local
digital-bank-sitcluster:transaction-service,account-service, andledger-service: service-specific*-sit.yml, sharedapplication-sit.yml, service defaults, and shared defaults.1/1.Remaining evidence/dependencies:
infra-sit#34must merge and be reconciled somfa.assurance.granted.v1.dlqis explicitly provisioned.No secrets or message payloads were recorded.
ramioooz commentedon Sep 5, 2026
Updated SIT infrastructure checkpoint (2026-09-05)
After merged
infra-sit#34, the governed event topics and DLQs are provisioned, includingmfa.assurance.granted.v1and its DLQ. The active consumer groups now include Account reservation/ledger outcomes, Transaction reservation/ledger/MFA assurance, and Notification transfer-created consumption. Notification Service is running the validated listener image and has an assignedevents.transfer.created.v1-0partition.The remaining acceptance work is a controlled representative transfer trace plus duplicate delivery and deterministic DLQ verification. No secrets or message payloads were recorded.
ramioooz commentedon Sep 5, 2026
Config Repo status
The SIT transport configuration requested by .github#213 is already present on
mainthrough config-repo#41. I verified the currentorigin/mainrevision in an isolated worktree:.dlqrecovery convention.ledger.posting.*.v1, grouptransaction-service-ledger, bounded exponential retry, and.dlqrecovery.ledger.posting.requested.v1, groupledger-service; the SIT infra topic set includes the governed source topics and.dlqcompanions.PLAINTEXTonly in the SIT profile, with the existing Accountallow-insecure-transportand Transactionsit-plaintext-enabledsafeguards.Focused verification passed: all 20 tracked YAML files parsed, the required transport contract checks passed, and
git diff --checkpassed. No follow-up Config Repo PR is opened because the requested settings are already merged and a duplicate/no-op PR would violate the scope.Related work: ledger-service#18, transaction-service#13, transaction-service#18, account-service#38, infra-sit#23, and infra-sit#29.
The Config Repo portion is complete; keep this task
In progresspending the representative transfer trace plus duplicate-delivery and deterministic-DLQ verification. Rollout is readiness-based: ensure the related service images and required topic provisioning are available, wait until Config Server serves the revision, then roll out Account, Transaction, and Ledger Services. No fixed delay is required between merges or rollout steps. AWS/UAT/PROD remain out of scope.ramioooz commentedon Sep 5, 2026
Implementation update: the existing merged SIT config enabled ledger transport but omitted Transaction Service reservation topic names, consumer group, and publisher retry/lease settings required by the already-existing Kafka adapters. Config Repo PR digital-bank-java/config-repo#44 adds only those missing non-secret values under transaction-service/transaction-service-sit.yml. Local YAML parsing, required-property assertions, whitespace validation, and secret-pattern checks pass. After merge, refresh Config Server and roll out Transaction, Account, and Ledger Services in digital-bank-sit for end-to-end verification.
ramioooz commentedon Sep 5, 2026
Implementation is available in config-repo#44. It adds the missing SIT reservation transport properties for Transaction Service, including governed topics, consumer group, retry policy, and publisher lease/retry settings. Account and Ledger SIT transport settings were already present on the configuration baseline. Verification passed: YAML parsing, required-property checks, diff hygiene, and secret scan. Merge this PR before refreshing Config Server and rolling out the three consumers for end-to-end SIT verification.
ramioooz commentedon Sep 6, 2026
Added PR #253 to align the Insomnia transfer workflow guide with the merged event-driven implementation.
The guide now distinguishes implemented behavior from remaining Sprint 3 SIT acceptance evidence: successful completion, insufficient-balance failure and release, duplicate delivery, malformed-event/DLQ handling, and Account/Ledger/Transaction/Kafka/AKHQ-DBeaver correlation. No runtime code or redundant tests were added.