Skip to content

TASK: Provision controlled SIT transfer acceptance fixture #261

Closed
2 of 2 issues completed
Closed

Description

@ramioooz

Type: Task

Parent: STORY: Orchestrate transfer saga with ledger-driven completion (#103)

Outcome:
Provide a repeatable, explicitly invoked local-SIT fixture for the final Sprint 3 transfer-saga acceptance.

Scope:

  • A temporary synthetic Auth fixture for the allowlisted transfer-orchestrator subject, with no raw credential committed to Git.
  • Synthetic source and destination accounts and a reconciled opening ledger/account balance fixture sufficient for one controlled transfer.
  • Idempotent execution, a clear synthetic-data marker, bounded cleanup, and redacted evidence.
  • Local Kubernetes SIT only; no UAT/PROD behavior and no public balance-update API.

Definition of Done:

  • Fixture execution leaves no temporary Auth Secret or deployment override.
  • Seeded records are clearly synthetic and ledger/account state is internally consistent.
  • A positive transfer, insufficient-funds rejection, duplicate terminal-event handling, and ledger-failure compensation can be evidenced through supported APIs/events.
  • The procedure is documented and linked to STORY: Orchestrate transfer saga with ledger-driven completion #103.

Related: #103

Activity

  1. self-assigned this
    on Sep 8, 2026
  2. added theissue type on Sep 9, 2026
  3. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    Implementation PRs are ready for review:

    • ledger-service #24: guarded, disabled-by-default SIT-only Ledger failure switch. It must merge before the compensation acceptance scenario.
    • infra-sit #43: disabled-by-default, namespace-guarded synthetic seed Job. It can merge independently.
    • .github #262: approved design, plan, and handoff update.

    No fixture has been enabled or deployed. After the PRs merge, the remaining work is the one controlled local-SIT run, evidence capture, cleanup verification, and Sprint 3 closeout.

  4. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    Acceptance checkpoint (2026-09-09): the first branch-artifact run reached Auth but transfer creation was denied by an API Gateway scope mismatch. The issue is tracked in parented Bug #263 and fixed by api-gateway#27.

    The runner readiness race was also fixed in infra-sit#43 at commit ff0c228. Ledger feature image build succeeded and the runner restored the original Ledger image after both attempts. Full acceptance remains pending merge of #27, #24, and #43.

  5. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    Correction to the evidence note: account-service serializes reservation event occurredAt with nanosecond precision while the Kafka header uses microsecond precision. Transaction Service now compares that field as an Instant while retaining strict matching for the other governed headers.

    PR: digital-bank-java/transaction-service#29
    CI: Maven, Helm, and container smoke checks passed.

    SIT was restored to its original images after diagnosis. #261 remains open until PR #29 is merged and the controlled positive transfer is rerun successfully.

  6. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    Controlled SIT acceptance remains open as of 2026-09-09. Ledger and Account compatibility PRs are available for review: ledger-service#25 and account-service#44. The latest run restored SIT successfully, but Transaction Service still DLQ'd the accepted reservation timestamp event despite the verified final image. No closure claim is made until the full runner passes.

  7. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    Controlled SIT acceptance remains open after the 2026-09-09 run.

    The exact Transaction compatibility image was deployed and verified by immutable image ID and live /app/app.jar checksum. The positive transfer still remained PENDING; the accepted reservation event was placed on the reservation DLQ for an occurred-at mismatch even though the observed header/payload difference was only 281ns. All services were restored to the baseline SIT images and are healthy. No PR or project item was closed.

  8. ramioooz commented on Sep 9, 2026

    @ramioooz
    MemberAuthor

    SIT acceptance evidence (2026-09-10):

    • Controlled synthetic seed validated: source 1000.0000/1000.0000 AED, destination 0.0000/0.0000 AED, opening ledger fixture balanced with two lines and net 0.0000.
    • Successful transfer of 10.0000 AED reached COMPLETED; account projection verified source 990.0000 and destination 10.0000.
    • Insufficient-funds transfer of 1001.0000 AED reached FAILED; no reservation row remained.
    • Ledger failure scenario of 5.0000 AED reached FAILED; reservation status verified RELEASED.
    • Duplicate Ledger completion replay consumed from partition 0 offset 2; transfer remained COMPLETED and transaction_terminal_event_outbox count remained exactly 1.
    • Temporary Auth fixture, Ledger failure hook, temporary service images, and fixture release were removed/restored. SIT workloads are healthy on baseline images.

    The original fixture PR merged as #43. A one-line Kafka whitespace matching correction is available in infra-sit PR #44. Acceptance was completed manually against the approved controlled fixture; keep this task open until PR #44 is reviewed and merged.

  9. ramioooz commented on Sep 10, 2026

    @ramioooz
    MemberAuthor

    Controlled SIT acceptance completed

    The approved local-SIT fixture acceptance passed after the supporting infrastructure change merged. Verified scenarios: successful transfer projection, insufficient-funds rejection without a reservation, Ledger failure with reservation release, and duplicate Ledger completion without duplicate terminal output. Temporary fixture state and deployment overrides were restored; no credentials or secret values were retained.

    Closes the acceptance-fixture task boundary under #103.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions