Repository navigation
Release 0.6.2 - #52
Merged
Merged
Conversation
The API now reads provider settings from an LLM integration's model_name after "#" (discolike-platform!1041), so a Bedrock key scoped to one AWS region works and Snowflake and watsonx become usable. Expose the accepted regions on DiscogenModels and give the CLI flags that build the suffix, so nobody has to hand-encode it.
CPython 3.15.0 is final, so 3.15 moves from the non-blocking prerelease job into the test matrix, the highest-resolution job runs on it, and both packages get the classifier. The full SDK and CLI suites, ty, and the built wheels at highest and lowest-direct resolution pass on 3.15.0 locally. Also dates the changelog section for the LLM provider region, account and project settings.
The platform added linkedin to contact bulk match and reordered the LLM provider request fields, so gen_requests --check against dev went red on the 0.6.2 release PR.
The polling kwarg was renamed from timeout to max_wait, which left three examples raising TypeError at the wait call, and a None address field broke enrich_crm_export's dict[str, str] return.
Release 0.6.2
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+31
to
+32
| settings = {key: value for key, value in (("region", region), ("account", account), ("project", project)) if value} | ||
| return f"{model_name}#{urlencode(settings)}" if settings else model_name |
There was a problem hiding this comment.
_with_model_settings adds another # when --model-name already contains the documented settings suffix. For example, --model-name "model#region=us-east-1" --region us-west-2 produces model#region=us-east-1#region=us-west-2, rather than changing the region. This affects create, update, and test-connection.
Merge existing settings with the flags, letting explicit flags win, or reject the combination before sending it.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/discolike-cli/src/discolike_cli/providers.py
Line: 31-32
Comment:
**Settings suffix gets duplicated**
`_with_model_settings` adds another `#` when `--model-name` already contains the documented settings suffix. For example, `--model-name "model#region=us-east-1" --region us-west-2` produces `model#region=us-east-1#region=us-west-2`, rather than changing the region. This affects `create`, `update`, and `test-connection`.
Merge existing settings with the flags, letting explicit flags win, or reject the combination before sending it.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
A model_name read back from llm-providers get already carries #region=..., so passing --region on update appended a second suffix the API rejects instead of changing the region.
fix(cli): let provider setting flags override a model_name suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM provider region/account/project settings and LinkedIn bulk contact match are live on the production API, Python 3.15 support. See CHANGELOG 0.6.2.
The PR appears safe to merge, with a non-blocking fix recommended for model names that already contain settings.
Fix with agent prompt
Summary
Releases SDK and CLI version 0.6.2.
Reviews (1) · Last reviewed commit: "Merge pull request #51 from discolike/re..." · Reviewed by Greptile