Skip to content

Add KNMI_MTG as a configuration using MTG-CPP input data - #26

Merged
KristianHMoller merged 7 commits into
dmidk:mainfrom
KristianHMoller:feature/download_MTG_CPP
Nov 5, 2026
Merged

KristianHMoller merged 7 commits into
dmidk:mainfrom
KristianHMoller:feature/download_MTG_CPP

Conversation

@KristianHMoller

@KristianHMoller KristianHMoller commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

KNMI have started producing MTG-CPP data based on the MTG satellite.
This has higher spatial and temporal resolution compared to MSG-CPP.
This PR adds the option of using this new dataset.

It can be invoked by calling sunflow with the flag --dataset KNMI_MTG.

Additionally, for transparency in the output, satellite is now a global attribute printed in the output. This means that it is now a required field in config.yaml for each configuration. This should avoid potential confusion regarding which satellite the output is based on images from.

@KristianHMoller
KristianHMoller marked this pull request as ready for review October 6, 2026 14:36
@KristianHMoller

Copy link
Copy Markdown
Collaborator Author

Verified to work for both --run_mode download (default) and --run_mode files

@ElloiseFangelLloyd

Copy link
Copy Markdown
Collaborator

Runs for me for --run_mode download (given an API key)! No problems from my end, looks good.

@ElloiseFangelLloyd ElloiseFangelLloyd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me running with the defaults!

@KristianHMoller

KristianHMoller commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author

Add a label for the satellite used to the metadata.

Edit: DONE

@KristianHMoller

Copy link
Copy Markdown
Collaborator Author

KNMI_MTG is not made the default yet.

@KristianHMoller

Copy link
Copy Markdown
Collaborator Author

@ElloiseFangelLloyd can this be approved and merged?
I changed my mind on having this PR make KNMI_MTG the default until we are ready to switch operationally. So the default remains unchanged

@ElloiseFangelLloyd

Copy link
Copy Markdown
Collaborator

I approved in this review when I tested it

Works for me running with the defaults!

No problem with me having the defaults be unchanged. I think the merge still appears as "Blocked" because the repo requires the review of someone with write access...it appears from my end that you need approving review from @irenelivia.

@KristianHMoller

Copy link
Copy Markdown
Collaborator Author

Could I get you to try approving it again @ElloiseFangelLloyd ? I have tried increasing your access level.

@KristianHMoller
KristianHMoller merged commit 85fb27e into dmidk:main Nov 5, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants