Repository navigation
fix(pass): return a copy from PassValue.Marshal - #693
Merged
Merged
Conversation
Store backends zero the bytes Marshal returns once they have written them. PassValue returned its own backing buffer, so saving a PassValue wiped the caller's secret. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
enabled auto-merge
October 13, 2026 13:08
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
joe0BAB
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store backends (macOS and Linux keychain, Windows credential manager, posixage) zero the bytes returned by Marshal once they have written them. PassValue.Marshal returned its own backing buffer, so saving a PassValue wiped the caller's secret value.
Marshal now returns a copy, matching Unmarshal, which already copies. Adds a test that clears the result of Marshal and checks the PassValue still holds its value.
Found while reviewing #687.
AI disclosure: the code, test and this description were written by Claude (Anthropic) through the alki coding agent, at my direction.