Repository navigation
chore: merge upstream v0.30.0 - #14
Merged
Merged
Conversation
Resolutions: - coordinator: take upstream mutex-guarded flowErr - base.go: keep fork failFlow; treat Unimplemented StreamLSN as optional (kafka/null/file/s3 would otherwise fail the flow) - mongo conn: upstream partial write results + fork shard-key overwrite filter, Cosmos TTL fix and write diagnostics - external tests: NewConnWithClient returns an error in the fork
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges adiom-data/dsync main (v0.30.0) into the fork:
ItemFailure,PartialWriteResultsConflict resolutions
coordinators/simple/coordinator.go: upstream mutex-guardedflowErrreplaces forksync.Once.connectors/common/base.go: forkfailFlowkept (superset of upstream NotifyError+cancel). Upstream testTestStandaloneFlowFailsAfterInitialCopyWhenStreamFailsexposed a fork bug: UnimplementedStreamLSN(kafka/null/file/s3) failed the flow →failLSNTrackingnow logs and continues forCodeUnimplemented.connectors/mongo/conn.go: upstream partial-results structure (indexedDocument,buildIndexedBulkModels,failuresFromBulkWrite) with fork changes ported in: Cosmos shard key in overwrite filter,cosmosValidTTLon inserts/updates, transient-code log levels, overwrite diagnostics.buildIndexedBulkModelstakes the namespace for TTL.NewConnWithClientreturns(conn, error)in the fork.Note:
TestMongoConnectorSuite/TestConnectorReadResumeCDCis flaky in the full external suite — also fails on current origin/main; passes in isolation.Test plan
go build ./...,go vet -composites=false -tags external ./...go test ./...go test -tags external ./connectors/mongo/against local mongo 8.0 replset (only the pre-existing ResumeCDC flake)Review follow-ups
TestFlowFailsWhenLSNTrackingFails(non-Unimplemented LSN error fails the flow; proven RED withoutfailFlow).PartialWriteResultsis never set by dsync): Cosmos source checkpoint may run ahead of sent events across namespaces; underPartialWriteResultsambiguous/transient write errors becomeItemFailureand bypass retry — do not enable it inbase.gowithout carryingtransientServerCodesover.