Repository navigation
Upgrade Settings and MultiLingual to 1.0.0-preview.3 - #4
Merged
Merged
Conversation
MultiLingual: TranslatedText writes and reads every language through SetAll and GetAllAsync(includeBase: true), so it no longer switches the request into the base language. Creates go through a new CreateAsync, which gives "" to base-language properties the body left out. HiLo keys stay, now only for Auditing's nested save. Settings: SettingGroupAuditObserver becomes SettingGroupAuditParticipant, which enlists the audit entry and its change rows in the settings save, so the entry commits with the change or not at all. It uses SettingWrite.GroupType instead of scanning the assembly. Tests cover the entry committing in the caller's save, a failed settings write leaving nothing behind, and a create under another language without every base property. Docs and documented counts updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the four
DotNetBoost.Settings.*and fourDotNetBoost.MultiLingual.*packages from1.0.0-preview.2to1.0.0-preview.3. Media and Auditing stay on preview.2.Settings
SettingGroupAuditObserver(anISettingWriteObserver, which ran after the commit) becomesSettingGroupAuditParticipant(anISettingWriteParticipant).EfCoreSettingWriteScope.Add. The entry now commits in the settings store's own save, or not at all. A failure to record fails the request instead of being logged and swallowed.SettingWrite.GroupType, so the assembly scan that rebuilt the name-to-type map is gone.MultiLingual
TranslatedTextwrites throughSetAlland reads throughGetAllAsync(includeBase: true). It no longer switches the request into the base language, andAssign/WithBaseValuesare gone.CreateAsync, which gives""to any base-language property the body left out. Without it, a create underAccept-Language: arwithout every English property would be refused (409).Tests
Three new tests, 160 → 163:
The README,
ARCHITECTURE-SLICES.mdand the documented test counts are updated to match.Verification
dotnet test -p:UseLocalDotNetBoost=false(published NuGet packages): 163/163 pass.dotnet testwith the local workspace (sibling library sources): 163/163 pass.Source control information is not availablewarnings. These come from the published Settings preview.3 packages, which list Source Link as a dependency; it's fixed in dotnetboost/settings but not released yet.🤖 Generated with Claude Code