Repository navigation
Keep Source Link out of the packages' dependencies - #12
Merged
Merged
Conversation
Microsoft.SourceLink.GitHub was referenced without PrivateAssets="All", so every published package from 1.0.0-preview.1 to preview.3 lists it as a dependency. Applications that install Settings download it, and its buildTransitive targets then run in their builds and warn "Source control information is not available". It is build-time only: it embeds source-control metadata into the PDBs, which still happens. Media, MultiLingual and Auditing already mark it PrivateAssets="All". Verified: packed locally, all six packages list the same dependencies as the published 1.0.0-preview.3 except for Microsoft.SourceLink.GitHub, which is gone; unit tests (210 x2) pass; and the two DotNetBoost samples, built against this source, no longer show the warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.SourceLink.GitHubwas referenced withoutPrivateAssets="All", so every published Settings package (1.0.0-preview.1topreview.3) lists it as a dependency. Applications that install Settings download it, and its targets then run in their builds and warn:It's build-time only: it embeds source-control metadata into the PDBs, and that still happens. This adds
PrivateAssets="All", as Media, MultiLingual and Auditing already have it.Applications keep the warning until a release with this fix ships.
Verification
1.0.0-preview.3, exceptMicrosoft.SourceLink.GitHub, which is gone.🤖 Generated with Claude Code