Pass the installing user and their Slack profile to the installation handler - #52
Merged
Merged
Conversation
When the install's user token carries the openid scope, look up openid.connect.userInfo and hand the email, verified flag and name to the installation handler. Installs without openid make no extra call, and a failed lookup still installs the workspace.
Workspace.InstallerUserId (9.0.4) is replaced by Workspace.Installer, which carries the user id whenever Slack reports an installer and the profile only when openid was granted.
johnkors
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkspaceInstaller: always the Slack user id, plus email, verified flag and name when the install requests theopenid,email,profileuser scopes, so an install can be tied to a real user without a separate sign-in.Workspace.InstallerUserIdfrom 9.0.4 moves onto the installer.