fix: pin web security fallback tools (ENG-8602) - #149
Open
briangreunke wants to merge 4 commits into
Open
briangreunke wants to merge 4 commits into
briangreunke wants to merge 4 commits into
Conversation
Brings the ENG-8602 branch onto current capabilities main. Keeps ADM-447's removal of surf, keeps the pinned Go, Katana, and kiterunner versions, and bumps web-security from main's 2.0.0 to 2.0.1. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Applies the repository ruff-format hook to lines merged from main so the changed-file pre-commit hooks pass. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The httpx guard mixed && and || without grouping, so a working ProjectDiscovery httpx on PATH or in ~/go/bin was reported missing and reinstalled, which fails offline. Group each location's check, and replace the substring test with tests that run the guard. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Automated agent review. This is not a human approval. [REVIEW] — Code ReviewVerdict: APPROVEReviewed Revisions
FindingsNo blocking findings. The prior review of
Non-blocking: Go 1.24.3 → 1.26.6 and katana 1.5.0 → 1.7.0 go beyond the current-main pins. The newer ProjectDiscovery pins need them. Validation
This approval applies only to |
briangreunke
marked this pull request as ready for review
September 25, 2026 13:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpxon PATH, in~/.pdtm/go/bin, or in~/go/bin, and treat Python'shttpxCLI as missing.surf.Revisions
main@02b775dcba854e447b5bf65589db446383aba142187259319969fbc8a8affb9bf740045ef22b98c4Acceptance evidence (ENG-8602)
git merge-base --is-ancestor origin/main HEAD: passbash -n capabilities/web-security/scripts/install_tools.sh: passuv run --with pytest pytest capabilities/web-security/tests/test_install_tools_offline.py: 27 passedtest_httpx_guard_accepts_projectdiscovery_httpx_on_pathfails against the previous guard.just validate: 26 validated, 0 failed. The 6 warnings are local environment checks for binaries that are not installed.CI
Lint, Detect changed capabilities, Validate YAML, Skill security scan, and skillspector all pass on
1872593.Scope
capabilities/web-security/scripts/install_tools.shcapabilities/web-security/tests/test_install_tools_offline.pycapabilities/web-security/capability.yamlSupersedes #148. Linear: ENG-8602. Tiger promotes the merged commit in ENG-8606.
🤖 Generated with Claude Code