Repository navigation
Removed the Shellvar container after each 'update-docs.sh' run with 'docker run --rm'. - #3347
Conversation
…docker run --rm'.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
📖 Documentation preview for this pull request has been deployed to Netlify: https://6afc12d2f4e632c245c778e0--vortex-docs.netlify.app This preview is rebuilt on every commit and is not the production documentation site. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3347 +/- ##
==========================================
+ Coverage 92.47% 92.66% +0.18%
==========================================
Files 107 115 +8
Lines 4944 5110 +166
Branches 3 49 +46
==========================================
+ Hits 4572 4735 +163
- Misses 372 375 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Code coverage (threshold: 90%) Per-class coverage |
|
Code coverage (threshold: 90%) Per-class coverage |
Summary
.vortex/docs/.utils/update-docs.shnow runs thedrevops/shellvar:1.7.0extraction withdocker run --rm, so Docker deletes the container as soon asshellvar extractexits.Without
--rm, everyahoy update-docsrun left behind an exited container with a random name likecondescending_williamsorupbeat_villani. On a machine that regenerates the variables docs regularly they pile up: one dev machine had 14 of them from the last 6 days, anddocker ps -afilled up with noise.After merge,
ahoy update-docsleaves no container behind andcontent/development/variables.mdxcomes out byte-identical. Containers already left behind aren't touched; clear them once withdocker container pruneordocker rmfiltered onancestor=drevops/shellvar:1.7.0. Every otherdocker runin the repo already passes--rmor is a deliberate long-running container.Before / After
Changes
.vortex/docs/.utils/update-docs.sh: added--rmto thedocker runthat callsshellvar extract.Checked by running
ahoy update-docs: the generated docs didn't change and no newdrevops/shellvarcontainer showed up indocker ps -a.Summary by CodeRabbit