Repository navigation
Fix Arrow filter pushdown on dictionary columns and on zoned timestamps in seconds or milliseconds - #677
Merged
Conversation
evertlammerts
force-pushed
the
fix-arrow-dictionary-pushdown
branch
2 times, most recently
from
October 16, 2026 13:41
3e2b05f to
4add9ba
Compare
evertlammerts
force-pushed
the
fix-arrow-dictionary-pushdown
branch
from
October 16, 2026 13:43
4add9ba to
08120cd
Compare
evertlammerts
enabled auto-merge
October 16, 2026 13:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #664, plus a wrong-result bug found on the way.
A pushed comparison on a dictionary-encoded Arrow column with binary, decimal or zoned timestamp values dereferenced null type info, raised an InternalException and invalidated the database. The filter walker received the column's index-side ArrowType; the engine stores the value type next to it. The walker now resolves a dictionary column, and a dictionary struct child, to its value ArrowType and Arrow schema node before building the scalar, as the engine's own scan does.
Separately, a pushed TIMESTAMPTZ comparison on a column stored in seconds or milliseconds truncated the microsecond constant into the column's unit, so a constant between two grid points returned wrong rows (plain columns too, on 1.5.6 as well). The scalar is now built in microseconds and labelled with the column's own zone, read from the Arrow schema the scan exports; pyarrow compares across units exactly, and ordinary constants still prune Parquet row groups.
Also:
Known limitations, pinned as expected failures: a constant finer than the column's unit loses Parquet row group pruning (correct rows, full scan); IN with an infinite zoned constant fails because the Python conversion turns infinity into a zoneless datetime. The polars backend has the same truncation since before this change and is out of scope.