Skip to content

fix(tooling): stop a duplicate co-author trailer in commits - #151

Merged
e128 merged 1 commit into
mainfrom
fix/coauthor-trailer-guard
Nov 11, 2026
Merged

e128 merged 1 commit into
mainfrom
fix/coauthor-trailer-guard

Conversation

@e128

@e128 e128 commented Nov 11, 2026

Copy link
Copy Markdown
Owner

Executive Summary

scripts/internal/commit.sh appends a name-only Co-Authored-By: Claude trailer on every commit. A message that already carried a trailer shipped with two of them, which happened on PR #150. The script now appends its trailer only when the message has none.

Code Changes

  • scripts/internal/commit.sh skips its trailer append when the message already has a Co-Authored-By: line.
  • AGENTS.md Git Conventions forbids a hand-written trailer and names commit.sh as the owner of that line.
  • scripts/README.md describes the conditional behavior.

Tests and Tooling

  • Build and tests did not run: no .cs file changed.
  • scripts/lint-shell.sh scripts/internal/commit.sh passes.
  • scripts/internal/precommit.sh reports clean.
  • scripts/internal/analyzer-release-check.sh, scripts/readme-table-diff.sh, and scripts/internal/readme-audit.sh report clean or no drift.

Review Guide

Read the trailer branch at the end of commit.sh. The rest is instruction and table text.

Rollback

Revert this commit. The risk is a repeated duplicate trailer, no runtime impact.

Links

🤖 Generated with Claude Code

scripts/internal/commit.sh appends `Co-Authored-By: Claude` itself. A
trailer written into the message therefore shipped twice. The script now
appends only when the message carries no trailer.

AGENTS.md states the rule, and scripts/README.md describes the new
behavior.

Co-Authored-By: Claude
@e128
e128 merged commit 23db3a3 into main Nov 11, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant