Skip to content

refactor(tooling): consolidate instruction layout and harden shipping - #154

Merged
e128 merged 2 commits into
mainfrom
refactor/instruction-layout
Nov 12, 2026
Merged

e128 merged 2 commits into
mainfrom
refactor/instruction-layout

Conversation

@e128

@e128 e128 commented Nov 12, 2026

Copy link
Copy Markdown
Owner

Executive Summary

The instruction set carried duplicate owners and stale rules, and the shipping script trusted the wrong upstream and could lose a squashed commit. This branch consolidates the instruction layout, hardens the shipping path, and bumps two analyzer and test-extension package families.

The default branch is now rejected by the ship script, and a failed PII scan or commit restores HEAD instead of leaving a squashed tree behind.

Full .NET build and test did not run on this branch. No .cs file changed, so the build outcome is unchanged. The local environment has no .NET 11 SDK (global.json requests 11.0.100), so a local restore attempt cannot run here. CI covers the build.

Code Changes

Instructions

  • CLAUDE.md is a thin Claude Code entry point that imports AGENTS.md.
  • Task-specific reference moved under lode/ with explicit pointers in AGENTS.md.
  • Nine rule files retired after their guidance merged into existing owners.
  • Test-first authoring is the policy. Implementation finishes before tests run.
  • Verify and ship phrases route through /yeet.

Shipping

  • scripts/verify-and-ship.sh rejects the default branch and a detached HEAD.
  • It accepts only origin/BRANCH as the upstream and squashes only unpushed commits.
  • It scans the whole squashed index and restores HEAD when the scan or the commit fails.
  • It keeps the squashed commit when the push fails and prints recovery steps.
  • scripts/internal/version-bump.sh counts the final commit message as a bump signal.

Dependencies

  • Meziantou.Analyzer 3.0.324 to 3.0.325.
  • Microsoft.Testing.Extensions.HangDump and Microsoft.Testing.Extensions.TrxReport 2.5.2 to 2.5.3.

Tests and Tooling

  • Added scripts/verify-and-ship-test.sh with 30 fixture cases.
  • scripts/ci.sh, the CI lint job, and scripts/check.sh --all run it when shipping scripts change.
  • Analyzer release files and the analyzer README rule table pass their checks (analyzer-release-check.sh and readme-table-diff.sh --analyzer report no drift).
  • Not run: scripts/check.sh --all. The missing .NET 11 SDK blocks it locally.

Review Guide

  • scripts/verify-and-ship.sh: the branch and upstream guards, the squash boundary, and the HEAD restore on failure.
  • AGENTS.md and .claude/rules/: the merged ownership after the rule-file retirement.
  • scripts/verify-and-ship-test.sh: the fixture cases that pin the new behavior.

Rollback

Revert the branch or the merge commit. Instruction changes take effect on the next session, so no runtime state needs cleanup.

Links

🤖 Generated with Claude Code

e128 added 2 commits November 11, 2026 19:00
Instructions
- Reduce CLAUDE.md to a thin Claude Code entry point that imports AGENTS.md.
- Merge the setup guidance into existing owners and retire nine rule files.
  The Dangerous Operations section is excluded.
- Move task-specific reference to lode/ with explicit pointers in AGENTS.md
  that work in both Claude Code and opencode.
- Set test-first authoring. Implementation finishes before tests run.
- Route verify and ship phrases through /yeet.

Shipping
- verify-and-ship.sh rejects the default branch and a detached HEAD.
- It accepts only origin/BRANCH as upstream and squashes only unpushed commits.
- It scans the whole squashed index and restores HEAD on a failed scan or commit.
- It keeps the squashed commit on a failed push and prints recovery steps.
- version-bump.sh counts the final commit message as a bump signal.

Tests and tooling
- Add verify-and-ship-test.sh with 30 fixture cases.
- Run it from ci.sh, the CI lint job, and check.sh --all when shipping scripts change.
- Full .NET build and test did not run. No .cs file changed.

Co-Authored-By: Claude
@e128
e128 merged commit 000f96c into main Nov 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant