Conversation
Fixes eclipse-threadx#55 NAND metadata access cast byte pointers to word pointers, and an odd block count could leave the page buffer misaligned. Both can fault on targets with strict alignment. Copy fixed-width metadata values through aligned locals and pad the NAND workspace before its page buffer. Account for padding in the capacity check. On 64-bit ULONG targets, four-byte metadata fields now match their fixed offsets; media formatted by the old layout may need reformatting. GCC 14: 6/6 default regression tests passed. The focused test passed with alignment sanitization on 32-bit and 64-bit builds; all new alignment lines were covered. Not run on hardware. Assisted-by: Codex (GPT-6-Sol) <noreply@openai.com>
fdesbiens
force-pushed
the
fix-nand-unaligned-access
branch
from
September 28, 2026 21:09
6a9507e to
a2b59d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
NAND metadata access cast byte pointers to word pointers, and an odd block count could leave the page buffer misaligned. Both can fault on targets with strict alignment.
This change copies fixed-width metadata values through aligned locals and pads the NAND workspace before its page buffer, including padding in the capacity check. On 64-bit ULONG targets, four-byte metadata fields now match their fixed offsets; media formatted by the old layout may need reformatting.
GCC 14: 6/6 default regression tests passed. The focused test passed with alignment sanitization on 32-bit and 64-bit builds; all new alignment lines were covered. Not run on hardware.
Assisted-by: Codex (GPT-6-Sol) noreply@openai.com