Repository navigation
Blink: read the options of PhpdocAlign - #290
Open
GErpeldinger wants to merge 2 commits into
Open
GErpeldinger wants to merge 2 commits into
GErpeldinger wants to merge 2 commits into
Conversation
Contributor
Author
|
CI here waits for a maintainer's approval, so I ran it on my fork. With the test commit alone, |
The expected output of the table comes from the PHP engine. WithConfig is a stub so the tests compile and fail on the output. The fix follows.
PhpdocAlign had one fixed style, left alignment with spacing 2 for @PARAM, whatever the config said. Read align, spacing and tags and port fixDocBlock for both alignments. Without options the rule now behaves like PHP-CS-Fixer's default, vertical with spacing 1: the dumper sends no options when they are the defaults, and the laravel set sets its own.
TomasVotruba
force-pushed
the
blink-phpdoc-align
branch
from
November 4, 2026 21:22
c53f5af to
7cf4c42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhpdocAlignhad one fixed style, whatever the config said: left alignment with spacing 2 for@param. On a project with the default config, that reported nearly every file with a docblock.It now reads
align,spacingandtags, and without options it behaves like PHP-CS-Fixer: vertical, spacing 1. Thelaravelset is not affected, because it sets its options.The first commit adds the tests, with expected output from the PHP engine and a stub so they compile, so CI shows them failing. The fix follows as a second commit.
🤖 Generated with Claude Code