Repository navigation
Blink: port 6 phpdoc fixers - #292
Merged
Merged
Conversation
…notation-without-dot, add-missing-param, param-order)
TomasVotruba
force-pushed
the
blink-port-phpdoc
branch
from
November 4, 2026 21:05
6e1ba7b to
9ecf65c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports 6 PHP-CS-Fixer phpdoc fixers to blink, validated for parity against the vendored PHP-CS-Fixer 3.95.27 test cases.
Landed
PhpdocArrayTypeFixerPhpdocListTypeFixerPhpdocTypesNoDuplicatesFixerPhpdocAnnotationWithoutDotFixerPhpdocAddMissingParamAnnotationFixer(configurable,only_untypeddefault true)PhpdocParamOrderFixerEach is registered in
PhpdocFixers()with its upstreamgetPriority()value, carries an upstream masterSourceURL(), and ships a parity test mirroring the upstreamprovideFixCases()expectations. README rule counts regenerated viabin/rule-counts.sh(blink 288 -> 294).Skipped
PhpdocTagNoNamedArgumentsFixer- requires docblock creation/insertion (ensureIsDocBlockWithAnnotation) plusAttributeAnalyzer/FullyQualifiedNameAnalyzer; heavy structural manipulation not yet modeled in blink.PhpdocToParamTypeFixer,PhpdocToReturnTypeFixer,PhpdocToPropertyTypeFixer- flagged risky in the task; parity could not be guaranteed, so deferred rather than shipping wrong behavior.