Repository navigation
Microsoft-only packages, AI attribution, and a guide for AI reviewers - #4
Merged
Merged
Conversation
- Tests: switch from xUnit (third-party) to MSTest 4.0.1 (Microsoft). Same 34 tests and expected values. - New RepositoryRulesTests enforce the ground rules: - only allowed Microsoft packages - no network APIs in app code - manifest declares only runFullTrust - Manifest: remove the unused systemAIModels capability. - Mark AI-generated code: header comments on every file Claude wrote or changed, and inline markers at Claude's changes in existing files. - README: "About this project" states the purpose (an app built with AI-generated code), local-only operation and the package policy. - CLAUDE.md: rules, layout, build/test, how an AI should check the README against the code, and the known README gaps to fix next. No app behavior changes; app code edits are comments only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
Addresses the two MSTEST0037 analyzer warnings from CI (IsNotEmpty and IsGreaterThan instead of IsTrue). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Housekeeping for the project's ground rules. No app behavior changes: the edits to app code are comments only, and every password stays the same.
No third-party packages. The tests now use MSTest, Microsoft's own test framework, instead of xUnit. The only packages left in the whole repo are Microsoft's:
Microsoft.WindowsAppSDKMicrosoft.Windows.SDK.BuildToolsMSTestRules that check themselves. A new
RepositoryRulesTestsfails if:HttpClient, sockets,System.Net, WebView…)runFullTrustRemoved an unused permission. The manifest asked for
systemAIModels(Windows' on-device AI models), which the app never uses. It's gone.AI-generated code is marked. Every file Claude wrote or changed has a header comment saying so. In existing files, the exact lines Claude added are marked too. Commits keep their
Co-Authored-By: Claudeline.README "About this project" states the purpose (an app built with AI-generated code), that it's local only, and the package policy.
CLAUDE.mdis a guide that any AI assistant reads first. It covers:How it was checked
HttpClientline, and adding an internet permission each made exactly one test fail.Next
Pull request #5 fixes the README gaps listed in
CLAUDE.md:passwordmask=, column handling, multi-line notes, settings validation. It also adds tests that tie each README claim to code.Generated by Claude Code