Repository navigation
passwordmask=, safe CSV handling, settings checks, README that matches the code - #5
Merged
Merged
Conversation
…s the code Engine (SecretKey.Core): - Csv.cs: RFC 4180 reader/writer; quoted and multi-line fields, line numbers in errors. - Processor: columns found by header name (any order or case); Title, Url, Username required; Notes and Password optional. - passwordmask= in Notes sets a per-account mask; an invalid one stops the run naming the line and account. - Every check runs before anything is written. - Old passwords are cleared from the input only if present, keeping all other values; written via a temp file and swap. - Validation.cs: root key (64 hex), date code (YYMM, month 01-12), masks (<= 64 chars, >= 4 of X/x/N/S, visible ASCII only). - SecretKeyConfig.cs + Processor.Run: one config/run path shared by both apps; relative paths resolve against the config folder; OutputPath must differ from InputPath. Apps: - CLI: usage text, exit codes, summary; never prints any part of the root key. - UI: uses the shared checks and Processor.Run, shows a summary, and drops the unused secretkey.exe lookup and console-app reference. Docs and repo: - README rewritten to match the code; ReadmeClaimsTests checks its facts against the code; CLAUDE.md maps each README section to code and tests (no known gaps). - .gitignore now excludes config.json (it holds the root key). Passwords for existing accounts are unchanged, except that sample Solterra now uses its passwordmask= note as the README describes. 103 tests; each new behavior was shown to fail its tests when broken. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Makes the README true. Every gap listed in
CLAUDE.mdis fixed, and tests now check the README's facts against the code.New and fixed behavior
passwordmask=in NotesTitle,Url,Usernameare required.Password1!gave the same password everywhere;2613acceptedconfig.jsonin gitRules (also in the README):
X/x/N/S. Other visible symbols like-or_are copied as-is.Shared code for both apps
The desktop app and the command-line app now use the same
config.jsonloading, the same checks and the same run code (Processor.Run).secretkey.exeit never used, and its reference to the command-line project.Documentation
config.jsonis the real secret.ReadmeClaimsTestsfails if the README's facts drift from the code: symbol set, limits, column names, settings, default mask, and the spec's character table.CLAUDE.mdmaps each README section to its code and tests. Known gaps: none.Passwords
All existing passwords are unchanged. The one intended change is the sample's Solterra row, which now honors its
passwordmask=xxxxxxxxNNNNnote:ydnvoivn3947, cross-checked with the separate implementation.How it was checked
passwordmask=, allowing 3-character masks, trimming CSV fields, rewriting the input needlessly, case-sensitive headers, accepting month 13, and writing output before checks finish. Changing a fact in the README was caught too.Generated by Claude Code