Repository navigation
Signed MSIX releases with Azure Artifact Signing (v2.0.0) - #6
Merged
Merged
Conversation
- release.yml: on a vX.Y.Z (or vX.Y.Z-rc.N) tag, three jobs.
- build (read-only): checks the tag against Directory.Build.props,
the manifest and CHANGELOG.md; tests; packages a self-contained,
unsigned x64 MSIX with winapp.
- sign (environment "release", OIDC, no stored secret): signs with
account edwest19, profile CodeSigning-Apps (East US); checks the
signature is valid, timestamped and made by EXPECTED_SIGNER;
records SHA-256.
- release (contents: write only): publishes the GitHub Release.
Design follows SecretPrinter; packaging follows SecretCsv. Actions
are pinned to the commits SecretPrinter uses, checked against tags.
- build.yml: actions pinned; every pull request now also packages the
unsigned MSIX, so packaging problems surface before a tag.
- Manifest: Publisher = the verified signer name (case-sensitive,
S=ny), Version 2.0.0.0, display name SecretKey, publisher Edwin West.
- Directory.Build.props (Version 2.0.0) and CHANGELOG.md added.
- package.pfx removed from SecretKey.slnx (it never existed).
- ReleaseRulesTests: publisher matches the signer, versions agree,
changelog entry exists, actions pinned, solution files exist, and
README's release facts match the workflow.
- README: Install and Releases sections. CLAUDE.md: rule 8 (releases
only through the workflow), layout and claims map.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
- scripts/Test-Msix.ps1: fails unless the MSIX has the expected publisher and version, depends on no other package (self-contained), contains the app, SecretKey.Core and the .NET runtime, and asks for no permission except runFullTrust. Run by build.yml on every pull request and by release.yml before signing. - Both workflows set DOTNET_CLI_TELEMETRY_OPTOUT=1 and WINAPP_CLI_TELEMETRY_OPTOUT=1 (winapp only checks for "1", per its source). - README, CLAUDE.md and the solution list the script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Sets up signed MSIX releases, ready for
v2.0.0. Merging this publishes nothing: a release only starts when you push a version tag, and signing waits for your approval.It combines your two proven setups:
winapp pack, signed withCodeSigning-Appson accountedwest19(East US).How a release runs (
.github/workflows/release.yml)releaseCN=Edwin West, O=Edwin West, L=Huntington, S=ny, C=US. Records its SHA-256.SecretKey-X.Y.Z-x64.msixand its.sha256, with the CHANGELOG entry as the release notesOther changes
Manifest:
Publisheris the exact signer name. It's case-sensitive (S=ny), as SecretCsv learned.2.0.0.0.Version is in
Directory.Build.props(2.0.0), and there's a newCHANGELOG.mdwith the 2.0.0 entry.build.yml: actions are pinned, and every pull request now packages the unsigned MSIX. If packaging breaks, you'll see it here, not at release time.SecretKey.slnx: droppedpackage.pfx, which never existed.New
ReleaseRulesTests:Each was shown to fail when its rule is broken.
README: new Install and Releases sections. CLAUDE.md: rule 8, releases only through the workflow.
Before the first release: setup only you can do
Azure. Create app registration
SecretKey-GitHubActions-Signing, with a federated credential:edwest19SecretKeyreleaseGive it the Artifact Signing Certificate Profile Signer role, the same way SecretPrinter's registration has it.
GitHub (SecretKey → Settings → Environments →
release).v*.AZURE_CLIENT_ID: the new registration's Application (client) IDAZURE_TENANT_ID: same as SecretPrinter'sAZURE_SUBSCRIPTION_ID: same as SecretPrinter'sThen push
v2.0.0-rc.1for a signed pre-release to test, andv2.0.0when you're happy.How it was checked
actionlint.winapp packpackages SecretKey-rctag, after the setup aboveGenerated by Claude Code