Skip to content

Record the immutable OIDC signing subject - #8

Merged
edwest19 merged 1 commit into
mainfrom
docs/immutable-oidc-subject
Nov 6, 2026
Merged

edwest19 merged 1 commit into
mainfrom
docs/immutable-oidc-subject

Conversation

@edwest19

@edwest19 edwest19 commented Nov 6, 2026

Copy link
Copy Markdown
Owner

What this does

Writes down how signing signs in, so the next setup or an AI reviewing the repo doesn't hit the subject mismatch we just fixed. No app or workflow behavior changes. The edit to release.yml is a comment.

  • README "Releases": the repository uses GitHub's immutable OIDC subject claims (Settings → Actions → OIDC). Azure's SecretKey-GitHubActions-Signing trusts exactly repo:edwest19@5809459/SecretKey@1239108708:environment:release. Renaming the repo, its owner or the release environment means updating the Azure credential.
  • CLAUDE.md rule 8 and release.yml's header comment say the same.
  • New test: ReleaseRulesTests.SigningSubject_IsStatedTheSameEverywhere_ForTheReleaseEnvironment fails if those three files disagree, or if the subject doesn't name the sign job's environment. It was checked by changing one file's subject to :staging.

The v2.0.0 release run's log confirms this is the subject GitHub now sends, and that signing succeeded with it.

After merging: delete the secretkey-release-classic federated credential in Azure, if you created it. The immutable one is the only one needed now.


Generated by Claude Code

The v2.0.0 release signed in with GitHub's immutable subject claim
(repo:edwest19@5809459/SecretKey@1239108708:environment:release),
which the Azure federated credential now trusts exclusively.

- README "Releases": the repo uses immutable subject claims, the exact
  subject Azure trusts, and that renaming the repo, owner or
  environment requires updating the Azure credential.
- CLAUDE.md rule 8 and release.yml's header comment state the same.
- ReleaseRulesTests: the three files must state one identical subject,
  and it must name the sign job's environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
@edwest19
edwest19 merged commit 9a93c85 into main Nov 6, 2026
2 checks passed
@edwest19
edwest19 deleted the docs/immutable-oidc-subject branch November 6, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants