Repository navigation
Record the immutable OIDC signing subject - #8
Merged
Merged
Conversation
The v2.0.0 release signed in with GitHub's immutable subject claim (repo:edwest19@5809459/SecretKey@1239108708:environment:release), which the Azure federated credential now trusts exclusively. - README "Releases": the repo uses immutable subject claims, the exact subject Azure trusts, and that renaming the repo, owner or environment requires updating the Azure credential. - CLAUDE.md rule 8 and release.yml's header comment state the same. - ReleaseRulesTests: the three files must state one identical subject, and it must name the sign job's environment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QSQZn3X5gDJdRjbqMfKRpd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Writes down how signing signs in, so the next setup or an AI reviewing the repo doesn't hit the subject mismatch we just fixed. No app or workflow behavior changes. The edit to
release.ymlis a comment.SecretKey-GitHubActions-Signingtrusts exactlyrepo:edwest19@5809459/SecretKey@1239108708:environment:release. Renaming the repo, its owner or thereleaseenvironment means updating the Azure credential.release.yml's header comment say the same.ReleaseRulesTests.SigningSubject_IsStatedTheSameEverywhere_ForTheReleaseEnvironmentfails if those three files disagree, or if the subject doesn't name the sign job's environment. It was checked by changing one file's subject to:staging.The v2.0.0 release run's log confirms this is the subject GitHub now sends, and that signing succeeded with it.
After merging: delete the
secretkey-release-classicfederated credential in Azure, if you created it. The immutable one is the only one needed now.Generated by Claude Code