Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to fix chained assignments followed by fused local stores in pycdc. The code below fails to decompile correctly from Python 3.13 and 3.14 bytecode and succeeds with this change:
Variations include three through six targets and a constant
Noneinstead ofread(). A genuine chain evaluates its right-hand side once and gives every target that same object. The parser already understands chained assignment, but fails to recognize a followingSTORE_FAST_STORE_FASTas a store; it can consequently classify aCOPYsequence as an expression operation and lose the chain. Adding that opcode to the existing store predicate is the entire production change, in the COPY/assignment lookahead.STORE_FAST_STORE_FASTwas introduced in Python 3.13, rather than 3.14, as recorded in the Python opcode documentation.