Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to preserve a handler's
continuewhen a large loop's back edge lands on anEXTENDED_ARGprefix. Large variants of the following loop currently lose thatcontinueduring decompilation:With thirty or sixty calls in the protected body, the affected part currently becomes:
A rejected row therefore reaches
result.appendinstead of starting the next iteration.The decoded loop starts at
FOR_ITER, while a valid back edge can target theEXTENDED_ARGprefix immediately before it. The current prefix recognizer excludes all Python 3.11+ input to avoid mistaking inline cache bytes for a prefix. The change permits a modern prefix only after checking word alignment and proving that every original two-byte instruction between the target andFOR_ITERisEXTENDED_ARG.The alignment and original-byte checks exclude CACHE tails from valid loop targets. The older prefix-recognition path keeps its existing handling.
The same prefix comparison is used when checking for later back edges, so recognizing the prefix does not close a loop that still has a path back to its start. When a forward conditional skips a back edge, that edge stays inside the branch it terminates; this preserves the branch's statements and its recompiled jumps.