Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to preserve synchronous iteration over an awaited collection. The code below currently decompiles with the wrong iteration protocol:
The loop is currently emitted as:
The producer must be awaited once and its result then consumed as a regular iterable through
__iter__. Anasync forinstead requires the asynchronous iteration protocol and no longer performs the source'sawait read()operation. A producer returning an ordinary list therefore no longer works.When the
FOR_ITERhandler sees an Await expression, it currently removes the await wrapper and marks the loop asynchronous. With this change,FOR_ITERalways selects synchronous iteration.GET_AITER/GET_ANEXTretain their separate genuine-async path, soasync for item in read()keeps its existing meaning.The source syntax begins in Python 3.5; the repair is not limited to a recent bytecode version.