Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to prevent a padded handler-return trailer from matching and swallowing the function's later return-value construction. The following source loses its final
return build(item)when the handler's return bytecode contains inert padding:With NOPs in the return trailers, pycdc currently emits an incomplete function that ends at the exception clause:
Some returns carry a value computed before cleanup. Treating only padding plus RETURN as a duplicated value-building tail can match unrelated mainline returns, swallowing their call or response construction and leaving an empty stack.
The change makes
sunk_return_mirror_mergeskip known padding to find the first meaningful operation and require a genuine value head: a load or an empty container construction. A carried-value return is left for the existing scope/value reconstruction. An actual independently constructed return tail remains eligible for matching.The same issue applies to the asynchronous variation, where
item = await read(). This matcher operates on Python 3.11+ exception-table layouts. The padding preserves jump targets and exception-table boundaries; it does not change which source path should return a value.