Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to distinguish marshalled slice constants from runtime
slicecalls. The following expressions must retain their different meanings:The normalizer currently converts any suitably shaped call named
sliceinto colon syntax. For the single-axis case,data[slice(None, stop, None)]becomes:That removes the global lookup and call, so a shadowed or effectful
slicecallable no longer runs.Conversely, a tuple containing actual serialized slice constants needs recursive normalization into colon syntax inside a multi-axis subscript. Currently
data[:, :]can become:This introduces runtime global lookups that the constant-index source does not perform.
The replacement normalizes genuine
PyObject::Slicevalues and tuples containing them, while preserving runtime calls. Variations includedata[:stop, :],data[:, :],data[1:stop:2, :, 7], and single- or multi-axis runtime slice arguments.Serialized slice objects are supported by marshal format 5, introduced in Python 3.14. Preserving actual runtime calls also matters for older bytecode; it does not require serialized slice constants.