Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am opening this PR to preserve nested conditional values in both arms of a comprehension element. The code below currently loses the entire comprehension and decompiles as
return rowson Python 3.14:The outer then arm constructs a dictionary containing another conditional expression. The pure-value scan handles nested conditionals in the else arm but can stop prematurely in the then arm. It also omits dedicated None-test jumps from its recognized conditional-jump family.
The change makes
genexpr_ternary_mergerecursively prove and skip a nested pure-value region in either arm, retaining the enclosing arm's actual final merge. This preserves the dictionary construction, decoding calls and their failures on the selected arm. A false outer condition still skips the inner decoding call entirely.The same reconstruction handles nested conditional call arguments and None tests in either arm:
Conditional expressions begin in Python 2.5. This repair restores these examples on the Python 3.12+ inlined-comprehension path; older comprehension reconstruction still has gaps.
docs/LIMITATIONS.mddistinguishes the repaired nested-arm case from those remaining older-version limitations.