Skip to content

fix(nodeenv): read config values without interpolation - #449

Open
r3wretrhy wants to merge 1 commit into
ekalinin:masterfrom
r3wretrhy:fix-config-percent
Open

r3wretrhy wants to merge 1 commit into
ekalinin:masterfrom
r3wretrhy:fix-config-percent

Conversation

@r3wretrhy

Copy link
Copy Markdown
Contributor

Fixes #440

Turned off interpolation in the config parser, as suggested in the issue. With that a percent-encoded mirror login (the form the README recommends for --mirror) can sit in setup.cfg or ~/.nodeenvrc without breaking nodeenv in that directory.

One side effect worth knowing: if someone wrote %% to work around the crash, they'll get %% back. I put that in the changelog entry.

There's a small test next to the quote-stripping one. Unit tests and flake8 pass locally; the Windows, zsh and fish shell tests were skipped since I don't have those here.

  • Tests cover the change
  • tox passes: the tests and flake8
  • CHANGES has an entry under Version [unreleased], if nodeenv's behavior changes
  • README.rst is updated, if the change affects what it documents
  • The title has the form type(scope): subject

@r3wretrhy

Copy link
Copy Markdown
Contributor Author

Rebased onto current master; kept the % config changelog entry alongside the recent -p PATH fix.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A % in a [nodeenv] config value crashes nodeenv

1 participant