Repository navigation
fix(nodeenv): ignore source trees during prebuilt installs - #450
Merged
Merged
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--prebuilttreats a cached source tree as a completed binary download.After a failed
--sourcebuild it copies that tree into the environment;when both source and prebuilt trees remain, copying finds multiple matches.
Keep source reuse for source builds, and require the version’s trailing
-when locating a prebuilt tree. Binary downloads and the arm64-to-x64 fallback
retain their behavior. The branch includes current master (
2226040),including release 1.11.1 and the fish activation fix. The #443 changelog
entry remains under unreleased.
Fixes #443.
and x64 fallback with real directory copying
CHANGEShas an unreleased entryREADME.rstneeds no changetype(scope): subjecttox -e py314: 403 passed, 61 skipped, 11 integration testsdeselected; flake8 passed
On the current unchanged upstream code, the identical nine focused cases
have five failures and four passes; all nine pass within the complete
suite with this fix. Five fresh CLI scenarios using a local HTTP mirror
and stub archives pass, covering source-failure retries, both retained
trees, source-cache reuse, activation and a real HTTP404 x64 fallback.
Current upstream passes two of those five scenarios. These are local
Python 3.14.7/macOS checks; unavailable fish and platform cases were
skipped, and the remote platform matrix was not run locally.
Earlier native validation on head
ae1f32cused the officialNode.js 24.0.0 archive, verified against its
published SHA256.
With a seeded source cache, it installed and ran Node.js 24.0.0 and npm
11.3.0;
--no-clean-srcretained both trees and a subsequent forced--clean-srcinstall removedsrc. That native validation was not rerunfor this changelog reconciliation; Node.js source compilation was not
exercised.
#447 changes the same glob line to escape literal path characters. An
earlier isolated combination retained both fixes and passed 18 focused
cases plus the five CLI scenarios under a bracketed temporary path.
Combining the changes still needs to retain both
glob.escapeand-*.