Skip to content

fix: make shipping group delivery_estimate and its end optional - #104

Merged
ellanan merged 2 commits into
mainfrom
fix/shipping-group-delivery-estimate-end
Oct 21, 2026
Merged

ellanan merged 2 commits into
mainfrom
fix/shipping-group-delivery-estimate-end

Conversation

@ellanan

@ellanan ellanan commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Type

  • Fix

Description

orders.svc omits delivery_estimate when it is not set, and omits end when only start was saved (both are omitempty). Every write schema requires start and accepts it without end. The SDK types required both.

  • ShippingGroupUpdateBody, CartShippingGroupBase: end is optional (delivery_estimate was already optional on the update body; now also on the cart request).
  • ShippingGroupBase, ShippingGroupResponse: delivery_estimate and end are optional.

One nock test added. Type-only otherwise.

Note: with strictNullChecks, code that reads delivery_estimate.end without a check will now fail to compile. That code can already fail at runtime.

Dependencies

orders.svc accepts a delivery_estimate with only a start date on PUT /v2/orders/:id/shipping-groups/:id; end is optional in its request schema.
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Test Results

  1 files  ±0   61 suites  ±0   2s ⏱️ ±0s
386 tests +1  386 ✅ +1  0 💤 ±0  0 ❌ ±0 
391 runs  +1  391 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 69ff4ab. ± Comparison against base commit 714c9b6.

♻️ This comment has been updated with latest results.

wberry22
wberry22 previously approved these changes Oct 20, 2026

@wberry22 wberry22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good from here, thanks. 👍

As a related aside, do the shipping group responses need updates to reflect optional end field (and/or the delivery_estimate object as a whole)? If so, could be its own MR, so approving this one.

@ellanan ellanan changed the title fix: make delivery_estimate end optional on order shipping group updates fix: make shipping group delivery_estimate and its end optional Oct 20, 2026
@ellanan
ellanan merged commit ac3ed03 into main Oct 21, 2026
11 checks passed
@ellanan
ellanan deleted the fix/shipping-group-delivery-estimate-end branch October 21, 2026 16:10
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 35.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants