Repository navigation
fix: make shipping group delivery_estimate and its end optional - #104
Merged
Merged
Conversation
orders.svc accepts a delivery_estimate with only a start date on PUT /v2/orders/:id/shipping-groups/:id; end is optional in its request schema.
wberry22
previously approved these changes
Oct 20, 2026
wberry22
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good from here, thanks. 👍
As a related aside, do the shipping group responses need updates to reflect optional end field (and/or the delivery_estimate object as a whole)? If so, could be its own MR, so approving this one.
wberry22
approved these changes
Oct 21, 2026
|
🎉 This PR is included in version 35.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Fix
Description
orders.svc omits
delivery_estimatewhen it is not set, and omitsendwhen onlystartwas saved (both areomitempty). Every write schema requiresstartand accepts it withoutend. The SDK types required both.ShippingGroupUpdateBody,CartShippingGroupBase:endis optional (delivery_estimatewas already optional on the update body; now also on the cart request).ShippingGroupBase,ShippingGroupResponse:delivery_estimateandendare optional.One nock test added. Type-only otherwise.
Note: with
strictNullChecks, code that readsdelivery_estimate.endwithout a check will now fail to compile. That code can already fail at runtime.Dependencies