Skip to content

feat: add transaction notes endpoints - #105

Merged
ellanan merged 3 commits into
mainfrom
feat/transaction-notes
Oct 21, 2026
Merged

ellanan merged 3 commits into
mainfrom
feat/transaction-notes

Conversation

@ellanan

@ellanan ellanan commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Type

  • Feature

Description

Adds notes on order transactions (orders/:id/transactions/:id/notes) to Transactions:

  • AllNotes({ order, transaction, limit, offset }): newest first. limit is at most 100. Also reads chained Limit() / Offset().
  • GetNote, CreateNote, UpdateNote. Create and update add type: 'note' to the body.
  • TransactionNote and TransactionNoteBody types. Text is 1–250 characters, and a transaction can have at most 50 notes. Shopper tokens are rejected.

There is no DeleteNote on purpose. Commerce Manager does not let users delete notes, and orders.svc returns 403 to every Commerce Manager role for delete.

Seven nock tests added: one for each method, plus tests for paging arguments, chained paging, and paging not carrying over to the next request.

Dependencies

Needed by MT-23896 (refund notes in Commerce Manager).


Written with Claude Code (Claude) for Ella Nan.

Adds AllNotes, GetNote, CreateNote, UpdateNote and DeleteNote to Transactions, with TransactionNote and TransactionNoteBody types.
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Test Results

  1 files  ±0   63 suites  +1   2s ⏱️ ±0s
400 tests +7  400 ✅ +7  0 💤 ±0  0 ❌ ±0 
405 runs  +7  405 ✅ +7  0 💤 ±0  0 ❌ ±0 

Results for commit dd70a81. ± Comparison against base commit 2b3d736.

♻️ This comment has been updated with latest results.

Comment thread src/types/transaction.d.ts Resolved
@ellanan
ellanan merged commit ce10e12 into main Oct 21, 2026
11 checks passed
@ellanan
ellanan deleted the feat/transaction-notes branch October 21, 2026 14:09
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 35.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants