Skip to content

Adapt to libcamel API changes in 3.58 - #1100

Merged
ryonakano merged 8 commits into
masterfrom
ryonakano/eds-camel-3.58
Oct 13, 2026
Merged

ryonakano merged 8 commits into
masterfrom
ryonakano/eds-camel-3.58

Conversation

@ryonakano

@ryonakano ryonakano commented Oct 10, 2026 •

Copy link
Copy Markdown
Member

Fixes #1042
Closes #1023

Changes Summary

  • Rebased Adapt to libcamel API changes in 3.57.1 #1023 on latest master
  • Revived Bobby's followup commit mentioned at Adapt to libcamel API changes in 3.57.1 #1023 (comment) which was removed accidentally by rebase in the above PR
  • Bump to libcamel 3.58 to fix the following build warning with 3.57.1:
        camel-1.2.vapi:1260.3-1260.33: warning: Creation method of abstract class cannot be public.
         1260 |             public MessageInfo.from_message (Camel.FolderSummary? summary, Camel.MimeMessage message);
              |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
  • Minor coding style improvements
    • Add comment after #endif
    • ConversationList: DRY
    • MoveOperation: Remove unnecessary #if

Checklists

I confirmed the following things on latest OS 8 Stable:

  • Build succeeds with libcamel 3.52.3 (installed from apt)
  • Build succeeds with libcamel 3.58.0 (installed from source code)
  • Build succeeds with libcamel 3.62.1 (installed from source code)

For anyone who want to double-check, here are the steps I performed to build and install newer libcamel:

git clone https://gitlab.gnome.org/GNOME/evolution-data-server.git
cd evolution-data-server/
git checkout <3.58.0 or 3.62.1>
sudo apt build-dep libcamel1.2-dev 
cmake . -B builddir -DENABLE_INTROSPECTION=ON -DENABLE_VALA_BINDINGS=ON
make -C builddir/ -j$(nproc)
sudo make -C builddir/ install

ryonakano and others added 3 commits October 10, 2026 12:47
The evolution-data-server 3.57.1 release contains API changes in libcamel,
which are incompatible with the previous versions. Bump the libcamel version
requirement, update the camel-1.2.vapi file and modify the sources accordingly.

Co-authored-by: Milan Crha <mcrha@redhat.com>
Co-authored-by: Bobby Rong <rjl931189261@126.com>
Fixes the following build warning:

    camel-1.2.vapi:1260.3-1260.33: warning: Creation method of abstract class cannot be public.
     1260 | 		public MessageInfo.from_message (Camel.FolderSummary? summary, Camel.MimeMessage message);
          | 		^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@ryonakano
ryonakano requested a review from a team October 10, 2026 05:01
@ryonakano ryonakano moved this from In progress to Needs review in Distro-agnostic Pantheon Oct 10, 2026
@github-project-automation github-project-automation Bot moved this from Needs review to Reviewer approved in Distro-agnostic Pantheon Oct 13, 2026
@danirabbit
danirabbit enabled auto-merge (squash) October 13, 2026 17:43
@ryonakano
ryonakano disabled auto-merge October 13, 2026 22:46
@ryonakano
ryonakano enabled auto-merge (squash) October 13, 2026 22:47
@ryonakano
ryonakano merged commit ff75d47 into master Oct 13, 2026
6 checks passed
@ryonakano
ryonakano deleted the ryonakano/eds-camel-3.58 branch October 13, 2026 22:48
@github-project-automation github-project-automation Bot moved this from Reviewer approved to Done in Distro-agnostic Pantheon Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Mail fails to build with latest evolution-data-server package

2 participants